Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df/Util_Net_V #105

Merged
merged 35 commits into from
Aug 9, 2022
Merged

df/Util_Net_V #105

merged 35 commits into from
Aug 9, 2022

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented Jul 27, 2022

This PR consists of small UI changes. No major functional changes are made.

  • Makes starting point icon background colors static white
  • Increases sample width to 400
  • Adds a section header for attributes in the starting point inspector
  • Moves starting point inspector "zoom to" button to the header
  • Moves trace name to the top of the advanced options
  • Adds label for trace name in advanced options
  • Prepends "Object ID" to asset group item numbers
  • Adds parentheses around quantitative values
  • Renames element results to feature results
  • Swaps the font size of the trace result picker and the current trace result name
  • Moves asset types into disclosure groups
  • Shows function type
  • Matches "Clear all results" button to "Trace" button
  • Only shows the results navigator if there's more than one completed trace
  • Makes trace name a tappable menu with options
  • Remove func makeZoomToButton as it only had 1 remaining call site

Other feedback not implemented here

  • Blur the component during starting point selection
    • Currently the component doesn't control its own container (it's in a floating panel) and so this wouldn't be feasible. Once floating panel supports detents and sheet behavior, this can be revisited.
  • Place the title of the component at the top
    • I checked the other platforms and they do not have this, nor do other Swift toolkit components.
  • Adding negative padding to fix the large gap above the list views.
    • This didn't work as expected and only moved the list into the view above it. Another option would be to use .listStyle(.plain)

@dfeinzimer dfeinzimer self-assigned this Jul 27, 2022
Base automatically changed from df/Util_Net_IV to v.next August 8, 2022 17:12
@dfeinzimer dfeinzimer marked this pull request as ready for review August 8, 2022 18:20
@dfeinzimer dfeinzimer merged commit 6479a35 into v.next Aug 9, 2022
@dfeinzimer dfeinzimer deleted the df/Util_Net_V branch August 9, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants