Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttachmentsFeatureElementView - Block empty file upload/download/preview #791

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented Jul 5, 2024

Apollo 768

@dfeinzimer dfeinzimer requested a review from mhdostal July 5, 2024 20:12
@dfeinzimer dfeinzimer self-assigned this Jul 5, 2024
@dfeinzimer dfeinzimer merged commit 8627595 into v.next Jul 8, 2024
@dfeinzimer dfeinzimer deleted the df/apollo768 branch July 8, 2024 16:55
Comment on lines +103 to +105
.alert(isPresented: $downloadAlertIsPresented) {
Alert(title: Text.emptyAttachmentDownloadErrorMessage)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This API is deprecated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you. Not sure how I missed that. #794

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants