-
Notifications
You must be signed in to change notification settings - Fork 396
Update Search samples to newest geocode locator #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things that I notice
- In the
Find place
sample, the results seem to be sparse. I think Tanner mentioned similar stuff so I'll treat it as expected - The coding style changes are interweaving in the comment changes, so I found it bit hard to tell if they would cause new problems. But ad-hoc testing makes me believe these 4 samples still work fine.
- Not sure if we should also update the READMEs. Some are referencing this service: https://www.arcgis.com/home/item.html?id=305f2e55e67f4389bef269669fc2e284 which should be OK, just want to double check.
arcgis-ios-sdk-samples/Search/Find place/FindPlaceViewController.swift
Outdated
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Find place/FindPlaceViewController.swift
Outdated
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Offline geocode/OfflineGeocodeViewController.swift
Outdated
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Offline geocode/OfflineGeocodeViewController.swift
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Offline geocode/OfflineGeocodeViewController.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Ting Chen <tchen@esri.com>
This link is preferred over the actual service link because the portal item provides helpful information about the service and also provides a link to the service link. |
I've reached out to Christa who helped us put this data together. She's on vacation at the moment so I'll convert this to a draft in the meantime. |
Christa has confirmed that the sample is behaving as expected. This PR is ready for review! |
arcgis-ios-sdk-samples/Search/Find place/FindPlaceViewController.swift
Outdated
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Find address/FindAddressViewController.swift
Outdated
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Reverse geocode/ReverseGeocodeViewController.swift
Outdated
Show resolved
Hide resolved
arcgis-ios-sdk-samples/Search/Reverse geocode/ReverseGeocodeViewController.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New data in search samples is working as expected
This PR updates all of the samples in the Search category affected by
common-samples/issues/2246
. The offline data for Offline geocode has been updated and the links to the geocoding service have been updated for all other samples.I updated the commenting style and made small improvements to the coding style (not meant to be an entire revamp of the source code).