Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog - escapeDisabled prevents all text edits #10337

Closed
2 of 6 tasks
iyouth23 opened this issue Sep 17, 2024 · 2 comments
Closed
2 of 6 tasks

Dialog - escapeDisabled prevents all text edits #10337

iyouth23 opened this issue Sep 17, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-09-30 - 2.13...

Comments

@iyouth23
Copy link

Check existing issues

Actual Behavior

Adding escapeDisabled: true to the calcite-dialog component will prevent text from being entered in any editable component (input, text-area, etc.).

Expected Behavior

escapeDisabled: true should prevent the dialog only from closing when the Escape key is pressed. It should not affect text inputs in other areas.

Reproduction Sample

https://codepen.io/iyouth66/pen/dyBBdMj?editors=1100

Reproduction Steps

  1. Open this codepen: https://codepen.io/iyouth66/pen/dyBBdMj?editors=1100
  2. Try to type in the calcite-text-area component
  3. Observe that you cannot add text at all.

Reproduction Version

2.11.0

Relevant Info

I see this handlePanelKeyDown method which appears to block all key presses from having any effect if escapeDisabled is true: https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/components/dialog/dialog.tsx#L799.

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

Needed for any migration from calcite-modal to calcite-dialog.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@iyouth23 iyouth23 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 17, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Sep 17, 2024
@driskull driskull mentioned this issue Sep 17, 2024
Merged
@DitwanP DitwanP added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 17, 2024
@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 17, 2024
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 17, 2024
driskull added a commit that referenced this issue Sep 18, 2024
@driskull
fix(dialog): only prevent default on escape key when escapeDisabled i…
0083630 
…s true (#10336)

**Related Issue:** #10337

## Summary

- only prevent default on escape key when escapeDisabled is true
- add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Sep 18, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Sep 18, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 18, 2024
@geospatialem geospatialem mentioned this issue Sep 21, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @iyouth23 @DitwanP