Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action, action-bar, action-group, action-menu, action-pad): add component tokens #10058

Merged
merged 44 commits into from
Aug 26, 2024
Merged

feat(action, action-bar, action-group, action-menu, action-pad): add component tokens #10058

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
89ce9f6
feat(action): add component tokens
alisonailea Jul 27, 2024
defca00
chore(action-bar): merge with dev
alisonailea Jul 27, 2024
e69d328
Merge branch 'dev' of github.com:Esri/calcite-components into ali-act…
alisonailea Jul 29, 2024
4d3f0d1
Merge branch 'dev' of github.com:Esri/calcite-components into ali-act…
alisonailea Jul 29, 2024
fb6dbe9
Merge branch 'dev' of github.com:Esri/calcite-components into ali-act…
alisonailea Jul 31, 2024
16cd0de
fix(action-bar): tokens tests and vrt
alisonailea Aug 1, 2024
e74166c
fix(action-group): tokens tests and vrt
alisonailea Aug 1, 2024
ddf88ca
fix(action-menu): tokens tests and chromatic
alisonailea Aug 1, 2024
a5c7a27
fix(action-pad): tokens tests and chromatic
alisonailea Aug 1, 2024
556d63c
fix(action): tokens tests, demos and chromatic
alisonailea Aug 1, 2024
eca3c74
chore(demo-theme, cssTokenValues): add token options
alisonailea Aug 1, 2024
a9a4e71
Merge branch 'dev' of github.com:Esri/calcite-components into ali-act…
alisonailea Aug 1, 2024
a528521
fix(action): text color pressed
alisonailea Aug 13, 2024
af92dac
Merge branch 'dev' of github.com:Esri/calcite-design-system into ali-…
alisonailea Aug 13, 2024
63c6a60
fix(action): update text color pressed name
alisonailea Aug 13, 2024
f631bfa
chore(cssTokenValues): add width & height default tests
alisonailea Aug 13, 2024
fa60346
fix(action-menu, action-group, action-bar): simplify tokens
alisonailea Aug 13, 2024
3e7dc42
fix(action-group): cleanup styles and tests
alisonailea Aug 14, 2024
16fb5ae
test(themed): update helpers
alisonailea Aug 14, 2024
f59b82b
Merge branch 'dev' of github.com:Esri/calcite-design-system into ali-…
alisonailea Aug 14, 2024
3e16871
test(action-pad, action-menu): fix e2e tests
alisonailea Aug 14, 2024
7f42e09
test(action-pad): remove extranious token from tests
alisonailea Aug 14, 2024
7c3aca4
fix(action-group): provide token default/fallback
alisonailea Aug 14, 2024
38d1fb3
test(action-bar): be more explicit in tests
alisonailea Aug 14, 2024
ddcd78d
test(action): add disabled active test to chromatic
alisonailea Aug 15, 2024
27281a1
chore(action): remove comments
alisonailea Aug 15, 2024
8d234f7
docs(action-bar): use the word “specifies”
alisonailea Aug 15, 2024
49056c3
docs(action-group): update gap token to note deprecation
alisonailea Aug 15, 2024
a8bb3cd
fix(action-pad, action-menu, action-group, action-bar): pass spacing …
alisonailea Aug 16, 2024
98db746
docs(action-pad): spelling
alisonailea Aug 17, 2024
3ad0ef9
chore(action-group): remove unused space tokens
alisonailea Aug 19, 2024
ac6d49f
test(action-pad, action-menu): add theme e2e tests
alisonailea Aug 20, 2024
9118c62
chore(themed): required prop
alisonailea Aug 20, 2024
0eedfff
Merge branch 'dev' of github.com:Esri/calcite-design-system into ali-…
alisonailea Aug 20, 2024
6eed680
chore(custom-theme): use cssTokenValues for chromatic testing
alisonailea Aug 21, 2024
0f1df33
test(action, action-pad, action-menu, action-group, action-bar): move…
alisonailea Aug 21, 2024
176e823
chore: fix placeholder-image refs
alisonailea Aug 21, 2024
885087c
chore(custom-theme): reorganize theming kitchen sink
alisonailea Aug 21, 2024
83f1785
fix(action): disabled styles
alisonailea Aug 22, 2024
d9e0125
Merge branch 'dev' of github.com:Esri/calcite-design-system into ali-…
alisonailea Aug 23, 2024
01616d2
chore(action-group): add back grid-gap
alisonailea Aug 23, 2024
f07e465
test(action-group): remove unnecessary test
alisonailea Aug 23, 2024
6ab08e0
fix(combobox): give variable a default
alisonailea Aug 23, 2024
4ef2fbe
fix(action-pad, action-menu, action-group, action-bar): simplify slot…
alisonailea Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(action): update text color pressed name
  • Loading branch information
@alisonailea
alisonailea committed Aug 13, 2024
commit 63c6a601e51ca09b281db17f76191a9843719caa
4 changes: 2 additions & 2 deletions packages/calcite-components/src/components/action/action.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ describe("calcite-action", () => {
shadowSelector: `.${CSS.button}`,
targetProp: "color",
},
"--calcite-action-text-color-hover": {
"--calcite-action-text-color-pressed": {
shadowSelector: `.${CSS.button}`,
targetProp: "color",
state: "hover",
Expand All @@ -258,7 +258,7 @@ describe("calcite-action", () => {
icon="configure-popup"
></calcite-action>`,
{
"--calcite-action-text-color-hover": {
"--calcite-action-text-color-pressed": {
shadowSelector: `.${CSS.button}`,
targetProp: "color",
},
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/action/action.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export const theming_TestOnly = (): string =>
"--calcite-action-background-color-hover",
"--calcite-action-background-color-pressed",
"--calcite-action-text-color",
"--calcite-action-text-color-hover",
"--calcite-action-text-color-pressed",
])}
}
</style>
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/demos/action.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@
--calcite-action-background-color-hover,
--calcite-action-background-color-pressed,
--calcite-action-text-color,
--calcite-action-text-color-hover
--calcite-action-text-color-pressed
"
>
<div class="child-action-bar">
Expand Down