Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox-item): add heading property (deprecates textLabel) and add label property #9987

Merged
merged 2 commits into from
Aug 12, 2024
Merged

feat(combobox-item): add heading property (deprecates textLabel) and add label property #9987

merged 2 commits into from
Aug 12, 2024

Conversation

aPreciado88
Copy link
Contributor

@aPreciado88 aPreciado88 commented Aug 7, 2024 •
edited by jcfranco
Loading

Related Issue: #8737

Summary

Update combobox component to:

  • Deprecate textLabel in favor of heading.
  • Add heading prop, which will fallback to textLabel if unspecified.
  • Add label prop, which will fallback to value if not specified.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Aug 7, 2024
@aPreciado88 aPreciado88 added this to the 2024-08-27 - Aug Release milestone Aug 7, 2024
@aPreciado88 aPreciado88 added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 7, 2024
@aPreciado88 aPreciado88 changed the title feat(combobox): update component's props for consistency feat(combobox-item): update component's props for consistency Aug 7, 2024
jcfranco
jcfranco approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Before merging, could you revisit the PR title before merging to highlight the new props? This is important as the titles are automatically pulled into the changelog. It’s helpful to frame them from a developer’s perspective, focusing on the benefits or changes they’ll see (similar to this PR).

packages/calcite-components/src/components/combobox-item/combobox-item.tsx Outdated
@@ -136,11 +136,21 @@ export class ComboboxItem implements ConditionalSlotComponent, InteractiveCompon
@Prop() shortHeading: string;

/** The component's text. */
@Prop({ reflect: true }) heading: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not reflect heading, as it is content. I don't recall why we were originally reflecting textLabel. 🤔

@aPreciado88 aPreciado88 changed the title feat(combobox-item): update component's props for consistency feat(combobox-item): add heading property (deprecates textLabel) and add label property Aug 12, 2024
@aPreciado88
Copy link
Contributor Author

@jcfranco I updated the PR with the requested changes. Does the new title look okay? 🐱‍👤

@aPreciado88 aPreciado88 added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 12, 2024
@jcfranco
Copy link
Member

@aPreciado88 aPreciado88 added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 12, 2024
@aPreciado88 aPreciado88 merged commit 90920a0 into dev Aug 12, 2024
14 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/8737-combobox-item-value-should-not-be-required branch August 12, 2024 22:18
benelan added a commit that referenced this pull request Aug 13, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into jcbenco/move-examples-…
0cccef5 
…to-monorepo

* origin/dev: (37 commits)
  chore: release next
  fix(tree,tree-item): replace checkbox with div and a11y attributes (#9849)
  feat(combobox-item): add `heading` property (deprecates `textLabel`) and add `label` property (#9987)
  chore: stop requesting review from ben/franco for all PRs (#10040)
  feat: add close-caption, transcript, flag, and flag-slash (#10039)
  build(deps): update dependency @cspell/eslint-plugin to v8.13.2 (#10036)
  build(deps): update angular-cli monorepo to v18.1.4 (#10035)
  build(deps): clean up ui-icon dependencies (#10024)
  build: update browserslist db (#10033)
  docs: update component READMEs (#10034)
  ci: fix chromatic and pr-semantic check trigger events (#10041)
  chore: release next
  fix(label): prevent focusing and toggling elements slotted within a label when a text selection occurs (#9990)
  build(deps): update dependency @floating-ui/dom to v1.6.9 (#10025)
  build(deps): update dependency postcss to v8.4.41 (#10027)
  ci: new version of husky no longer need npx (#10030)
  build(deps): update dependency lerna to v8.1.8 (#10026)
  build(deps): update dependency chromatic to v11.7.0 (#9995)
  build(deps): update dependency eslint-plugin-jsdoc to v48.11.0 (#9997)
  chore: release next
  ...
@benelan benelan mentioned this pull request Aug 28, 2024
Merged
benelan added a commit that referenced this pull request Aug 28, 2024
@benelan @github-actions
chore: release main (#10171)
a5bb109 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.31.0</summary>

##
[3.31.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.30.0...@esri/calcite-ui-icons@3.31.0)
(2024-08-28)


### Features

* Add close-caption, transcript, flag, and flag-slash
([#10039](#10039))
([85c7d69](85c7d69))
* Add layer-connection
([#10067](#10067))
([46dd2ee](46dd2ee))


### Bug Fixes

* Update close-caption, and transcript
([#10077](#10077))
([2e86904](2e86904))
</details>

<details><summary>@esri/calcite-components: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.1...@esri/calcite-components@2.12.0)
(2024-08-28)


### Features

* **accordion, accordion-item:** Add component tokens
([#9861](#9861))
([48f7f08](48f7f08))
* **action, action-bar, action-group, action-menu, action-pad:** Add
component tokens
([#10058](#10058))
([de96c24](de96c24))
* **alert:** Add 'queue' property to prioritize the ordering of alerts
when opened
([#10029](#10029))
([3aa47a4](3aa47a4))
* **combobox-item:** Add `heading` property (deprecates `textLabel`) and
add `label` property
([#9987](#9987))
([90920a0](90920a0))
* **dialog:** Add CSS variables to offset the position
([#9904](#9904))
([660f0c5](660f0c5))
* **dialog:** Add escapeDisabled property
([#10081](#10081))
([1ca8fba](1ca8fba))
* **dialog:** Add outsideCloseDisabled property
([#9978](#9978))
([f1d89b9](f1d89b9))
* **dialog:** Add resizable and dragEnabled properties
([#9804](#9804))
([e3e499e](e3e499e))
* **icon:** Add component tokens
([#10062](#10062))
([34d5689](34d5689))
* **input-time-zone:** Display selected time zone country in region mode
selection
([#9988](#9988))
([1575729](1575729))
* **loader:** Add `determinate-value` type
([#9957](#9957))
([7f21726](7f21726))
* **panel:** Add '--calcite-panel-content-space' style
([#10117](#10117))
([0e3ebcb](0e3ebcb))
* **table:** Update multiple selection iconography
([#10125](#10125))
([f2b2016](f2b2016))
* **tooltip:** Allow focusing and clicking on interactive elements
within a tooltip
([#9914](#9914))
([a3c144c](a3c144c))


### Bug Fixes

* **accordion-item:** Align focus styles across browsers
([#9944](#9944))
([2e29b42](2e29b42))
* **alert:** Properly form a queue of alerts
([#10032](#10032))
([b24d6ac](b24d6ac))
* **color-picker:** Prevent text selection when using color
sliders/field
([#10043](#10043))
([ab33e4d](ab33e4d))
* **combobox, input-date-picker, input-number, input-text,
input-time-picker, input, radio-button-group, segmented-control, select,
text-area:** Use toAriaBoolean in aria-invalid attribute to provide
valid AT error messaging
([#10079](#10079))
([78bc096](78bc096))
* **combobox:** Update placeholder-icon color
([#9956](#9956))
([d916ca4](d916ca4))
* **dialog, flow-item:** Slotted closable panels should not close the
component
([#10130](#10130))
([ce2513d](ce2513d))
* **dialog:** Allow shell to be slotted inside
([#10118](#10118))
([ea3a6de](ea3a6de))
* **dialog:** Fix escapeDisabled when the escape key is pressed on the
panel
([#10097](#10097))
([9a5f1f1](9a5f1f1))
* Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit
properly
([#9958](#9958))
([7e2764f](7e2764f))
* **filter:** Fix setFocus method
([#10149](#10149))
([f4a959a](f4a959a))
* **input-date-picker:** Fix selection for the "bs" and "it-CH" locales
([#9976](#9976))
([368d9e2](368d9e2))
* **input-date-picker:** Prevent console error when using a lang
([#10162](#10162))
([e7bf604](e7bf604))
* **input-time-zone:** Translate region names
([#9940](#9940))
([f975adb](f975adb))
* **input, combobox, input-date-picker, input-number, input-text,
input-time-picker, radio-button-group, segmented-control, select,
text-area:** Provide clear field error messaging for AT
([#9880](#9880))
([46ad7d2](46ad7d2))
* **input, input-number, input-text:** No longer set focus when a
validation message is clicked
([#10008](#10008))
([529bb5a](529bb5a))
* **label:** Prevent focusing and toggling elements slotted within a
label when a text selection occurs
([#9990](#9990))
([49d6ae1](49d6ae1))
* **list-item:** Prevent scrolling when item is focused.
([#9948](#9948))
([eab1e06](eab1e06))
* **panel:** Define heading and description line height
([#10085](#10085))
([5478eb9](5478eb9))
* **slider:** Prevent text selection when using the slider
([#10073](#10073))
([04bf325](04bf325))
* **slider:** Resolve step & snap floating point precision
([#10148](#10148))
([613bc47](613bc47))
* **stepper-item:** Update component to take full width when parent's
layout is "vertical"
([#10009](#10009))
([03a5a30](03a5a30))
* **tree,tree-item:** Replace checkbox with div and a11y attributes
([#9849](#9849))
([b1ac951](b1ac951))


### Performance Improvements

* **input-time-zone:** Improve memory footprint by leveraging browser
cache and releasing utils after their use
([#9945](#9945))
([a3d2141](a3d2141))


### Reverts

* "build(deps): remove unused cheerio package
([#10049](#10049))"
([#10057](#10057))
([d271ab1](d271ab1))
* Add stories
([#10131](#10131))
([e3a6590](e3a6590))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.31.0-next.4 to 3.31.0
</details>

<details><summary>@esri/calcite-components-angular: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.1...@esri/calcite-components-angular@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

<details><summary>@esri/calcite-components-react: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.1...@esri/calcite-components-react@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan added a commit that referenced this pull request Aug 28, 2024
@benelan @github-actions
chore: release main (#10171)
1f9017e 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.31.0</summary>

##
[3.31.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.30.0...@esri/calcite-ui-icons@3.31.0)
(2024-08-28)


### Features

* Add close-caption, transcript, flag, and flag-slash
([#10039](#10039))
([85c7d69](85c7d69))
* Add layer-connection
([#10067](#10067))
([46dd2ee](46dd2ee))


### Bug Fixes

* Update close-caption, and transcript
([#10077](#10077))
([2e86904](2e86904))
</details>

<details><summary>@esri/calcite-components: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.1...@esri/calcite-components@2.12.0)
(2024-08-28)


### Features

* **accordion, accordion-item:** Add component tokens
([#9861](#9861))
([48f7f08](48f7f08))
* **action, action-bar, action-group, action-menu, action-pad:** Add
component tokens
([#10058](#10058))
([de96c24](de96c24))
* **alert:** Add 'queue' property to prioritize the ordering of alerts
when opened
([#10029](#10029))
([3aa47a4](3aa47a4))
* **combobox-item:** Add `heading` property (deprecates `textLabel`) and
add `label` property
([#9987](#9987))
([90920a0](90920a0))
* **dialog:** Add CSS variables to offset the position
([#9904](#9904))
([660f0c5](660f0c5))
* **dialog:** Add escapeDisabled property
([#10081](#10081))
([1ca8fba](1ca8fba))
* **dialog:** Add outsideCloseDisabled property
([#9978](#9978))
([f1d89b9](f1d89b9))
* **dialog:** Add resizable and dragEnabled properties
([#9804](#9804))
([e3e499e](e3e499e))
* **icon:** Add component tokens
([#10062](#10062))
([34d5689](34d5689))
* **input-time-zone:** Display selected time zone country in region mode
selection
([#9988](#9988))
([1575729](1575729))
* **loader:** Add `determinate-value` type
([#9957](#9957))
([7f21726](7f21726))
* **panel:** Add '--calcite-panel-content-space' style
([#10117](#10117))
([0e3ebcb](0e3ebcb))
* **table:** Update multiple selection iconography
([#10125](#10125))
([f2b2016](f2b2016))
* **tooltip:** Allow focusing and clicking on interactive elements
within a tooltip
([#9914](#9914))
([a3c144c](a3c144c))


### Bug Fixes

* **accordion-item:** Align focus styles across browsers
([#9944](#9944))
([2e29b42](2e29b42))
* **alert:** Properly form a queue of alerts
([#10032](#10032))
([b24d6ac](b24d6ac))
* **color-picker:** Prevent text selection when using color
sliders/field
([#10043](#10043))
([ab33e4d](ab33e4d))
* **combobox, input-date-picker, input-number, input-text,
input-time-picker, input, radio-button-group, segmented-control, select,
text-area:** Use toAriaBoolean in aria-invalid attribute to provide
valid AT error messaging
([#10079](#10079))
([78bc096](78bc096))
* **combobox:** Update placeholder-icon color
([#9956](#9956))
([d916ca4](d916ca4))
* **dialog, flow-item:** Slotted closable panels should not close the
component
([#10130](#10130))
([ce2513d](ce2513d))
* **dialog:** Allow shell to be slotted inside
([#10118](#10118))
([ea3a6de](ea3a6de))
* **dialog:** Fix escapeDisabled when the escape key is pressed on the
panel
([#10097](#10097))
([9a5f1f1](9a5f1f1))
* Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit
properly
([#9958](#9958))
([7e2764f](7e2764f))
* **filter:** Fix setFocus method
([#10149](#10149))
([f4a959a](f4a959a))
* **input-date-picker:** Fix selection for the "bs" and "it-CH" locales
([#9976](#9976))
([368d9e2](368d9e2))
* **input-date-picker:** Prevent console error when using a lang
([#10162](#10162))
([e7bf604](e7bf604))
* **input-time-zone:** Translate region names
([#9940](#9940))
([f975adb](f975adb))
* **input, combobox, input-date-picker, input-number, input-text,
input-time-picker, radio-button-group, segmented-control, select,
text-area:** Provide clear field error messaging for AT
([#9880](#9880))
([46ad7d2](46ad7d2))
* **input, input-number, input-text:** No longer set focus when a
validation message is clicked
([#10008](#10008))
([529bb5a](529bb5a))
* **label:** Prevent focusing and toggling elements slotted within a
label when a text selection occurs
([#9990](#9990))
([49d6ae1](49d6ae1))
* **list-item:** Prevent scrolling when item is focused.
([#9948](#9948))
([eab1e06](eab1e06))
* **panel:** Define heading and description line height
([#10085](#10085))
([5478eb9](5478eb9))
* **slider:** Prevent text selection when using the slider
([#10073](#10073))
([04bf325](04bf325))
* **slider:** Resolve step & snap floating point precision
([#10148](#10148))
([613bc47](613bc47))
* **stepper-item:** Update component to take full width when parent's
layout is "vertical"
([#10009](#10009))
([03a5a30](03a5a30))
* **tree,tree-item:** Replace checkbox with div and a11y attributes
([#9849](#9849))
([b1ac951](b1ac951))


### Performance Improvements

* **input-time-zone:** Improve memory footprint by leveraging browser
cache and releasing utils after their use
([#9945](#9945))
([a3d2141](a3d2141))


### Reverts

* "build(deps): remove unused cheerio package
([#10049](#10049))"
([#10057](#10057))
([d271ab1](d271ab1))
* Add stories
([#10131](#10131))
([e3a6590](e3a6590))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.31.0-next.4 to 3.31.0
</details>

<details><summary>@esri/calcite-components-angular: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.1...@esri/calcite-components-angular@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

<details><summary>@esri/calcite-components-react: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.1...@esri/calcite-components-react@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@benelan benelan mentioned this pull request Aug 28, 2024
Merged
benelan added a commit that referenced this pull request Aug 28, 2024
@benelan @github-actions
chore: release main (#10171)
ada6d5a 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.31.0</summary>

##
[3.31.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.30.0...@esri/calcite-ui-icons@3.31.0)
(2024-08-28)


### Features

* Add close-caption, transcript, flag, and flag-slash
([#10039](#10039))
([85c7d69](85c7d69))
* Add layer-connection
([#10067](#10067))
([46dd2ee](46dd2ee))


### Bug Fixes

* Update close-caption, and transcript
([#10077](#10077))
([2e86904](2e86904))
</details>

<details><summary>@esri/calcite-components: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.1...@esri/calcite-components@2.12.0)
(2024-08-28)


### Features

* **accordion, accordion-item:** Add component tokens
([#9861](#9861))
([48f7f08](48f7f08))
* **action, action-bar, action-group, action-menu, action-pad:** Add
component tokens
([#10058](#10058))
([de96c24](de96c24))
* **alert:** Add 'queue' property to prioritize the ordering of alerts
when opened
([#10029](#10029))
([3aa47a4](3aa47a4))
* **combobox-item:** Add `heading` property (deprecates `textLabel`) and
add `label` property
([#9987](#9987))
([90920a0](90920a0))
* **dialog:** Add CSS variables to offset the position
([#9904](#9904))
([660f0c5](660f0c5))
* **dialog:** Add escapeDisabled property
([#10081](#10081))
([1ca8fba](1ca8fba))
* **dialog:** Add outsideCloseDisabled property
([#9978](#9978))
([f1d89b9](f1d89b9))
* **dialog:** Add resizable and dragEnabled properties
([#9804](#9804))
([e3e499e](e3e499e))
* **icon:** Add component tokens
([#10062](#10062))
([34d5689](34d5689))
* **input-time-zone:** Display selected time zone country in region mode
selection
([#9988](#9988))
([1575729](1575729))
* **loader:** Add `determinate-value` type
([#9957](#9957))
([7f21726](7f21726))
* **panel:** Add '--calcite-panel-content-space' style
([#10117](#10117))
([0e3ebcb](0e3ebcb))
* **table:** Update multiple selection iconography
([#10125](#10125))
([f2b2016](f2b2016))
* **tooltip:** Allow focusing and clicking on interactive elements
within a tooltip
([#9914](#9914))
([a3c144c](a3c144c))


### Bug Fixes

* **accordion-item:** Align focus styles across browsers
([#9944](#9944))
([2e29b42](2e29b42))
* **alert:** Properly form a queue of alerts
([#10032](#10032))
([b24d6ac](b24d6ac))
* **color-picker:** Prevent text selection when using color
sliders/field
([#10043](#10043))
([ab33e4d](ab33e4d))
* **combobox, input-date-picker, input-number, input-text,
input-time-picker, input, radio-button-group, segmented-control, select,
text-area:** Use toAriaBoolean in aria-invalid attribute to provide
valid AT error messaging
([#10079](#10079))
([78bc096](78bc096))
* **combobox:** Update placeholder-icon color
([#9956](#9956))
([d916ca4](d916ca4))
* **dialog, flow-item:** Slotted closable panels should not close the
component
([#10130](#10130))
([ce2513d](ce2513d))
* **dialog:** Allow shell to be slotted inside
([#10118](#10118))
([ea3a6de](ea3a6de))
* **dialog:** Fix escapeDisabled when the escape key is pressed on the
panel
([#10097](#10097))
([9a5f1f1](9a5f1f1))
* Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit
properly
([#9958](#9958))
([7e2764f](7e2764f))
* **filter:** Fix setFocus method
([#10149](#10149))
([f4a959a](f4a959a))
* **input-date-picker:** Fix selection for the "bs" and "it-CH" locales
([#9976](#9976))
([368d9e2](368d9e2))
* **input-date-picker:** Prevent console error when using a lang
([#10162](#10162))
([e7bf604](e7bf604))
* **input-time-zone:** Translate region names
([#9940](#9940))
([f975adb](f975adb))
* **input, combobox, input-date-picker, input-number, input-text,
input-time-picker, radio-button-group, segmented-control, select,
text-area:** Provide clear field error messaging for AT
([#9880](#9880))
([46ad7d2](46ad7d2))
* **input, input-number, input-text:** No longer set focus when a
validation message is clicked
([#10008](#10008))
([529bb5a](529bb5a))
* **label:** Prevent focusing and toggling elements slotted within a
label when a text selection occurs
([#9990](#9990))
([49d6ae1](49d6ae1))
* **list-item:** Prevent scrolling when item is focused.
([#9948](#9948))
([eab1e06](eab1e06))
* **panel:** Define heading and description line height
([#10085](#10085))
([5478eb9](5478eb9))
* **slider:** Prevent text selection when using the slider
([#10073](#10073))
([04bf325](04bf325))
* **slider:** Resolve step & snap floating point precision
([#10148](#10148))
([613bc47](613bc47))
* **stepper-item:** Update component to take full width when parent's
layout is "vertical"
([#10009](#10009))
([03a5a30](03a5a30))
* **tree,tree-item:** Replace checkbox with div and a11y attributes
([#9849](#9849))
([b1ac951](b1ac951))


### Performance Improvements

* **input-time-zone:** Improve memory footprint by leveraging browser
cache and releasing utils after their use
([#9945](#9945))
([a3d2141](a3d2141))


### Reverts

* "build(deps): remove unused cheerio package
([#10049](#10049))"
([#10057](#10057))
([d271ab1](d271ab1))
* Add stories
([#10131](#10131))
([e3a6590](e3a6590))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.31.0-next.4 to 3.31.0
</details>

<details><summary>@esri/calcite-components-angular: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.1...@esri/calcite-components-angular@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

<details><summary>@esri/calcite-components-react: 2.12.0</summary>

##
[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.1...@esri/calcite-components-react@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@benelan benelan mentioned this pull request Aug 28, 2024
Closed
benelan added a commit that referenced this pull request Aug 28, 2024
@benelan @github-actions
chore: release main (#10171) (#10172)
ce8eb8b 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.31.0</summary>

##

[3.31.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.30.0...@esri/calcite-ui-icons@3.31.0)
(2024-08-28)


### Features

* Add close-caption, transcript, flag, and flag-slash
([#10039](#10039))

([85c7d69](85c7d69))
* Add layer-connection
([#10067](#10067))

([46dd2ee](46dd2ee))


### Bug Fixes

* Update close-caption, and transcript
([#10077](#10077))

([2e86904](2e86904))
</details>

<details><summary>@esri/calcite-components: 2.12.0</summary>

##

[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.1...@esri/calcite-components@2.12.0)
(2024-08-28)


### Features

* **accordion, accordion-item:** Add component tokens
([#9861](#9861))

([48f7f08](48f7f08))
* **action, action-bar, action-group, action-menu, action-pad:** Add
component tokens
([#10058](#10058))

([de96c24](de96c24))
* **alert:** Add 'queue' property to prioritize the ordering of alerts
when opened
([#10029](#10029))

([3aa47a4](3aa47a4))
* **combobox-item:** Add `heading` property (deprecates `textLabel`) and
add `label` property
([#9987](#9987))

([90920a0](90920a0))
* **dialog:** Add CSS variables to offset the position
([#9904](#9904))

([660f0c5](660f0c5))
* **dialog:** Add escapeDisabled property
([#10081](#10081))

([1ca8fba](1ca8fba))
* **dialog:** Add outsideCloseDisabled property
([#9978](#9978))

([f1d89b9](f1d89b9))
* **dialog:** Add resizable and dragEnabled properties
([#9804](#9804))

([e3e499e](e3e499e))
* **icon:** Add component tokens
([#10062](#10062))

([34d5689](34d5689))
* **input-time-zone:** Display selected time zone country in region mode
selection
([#9988](#9988))

([1575729](1575729))
* **loader:** Add `determinate-value` type
([#9957](#9957))

([7f21726](7f21726))
* **panel:** Add '--calcite-panel-content-space' style
([#10117](#10117))

([0e3ebcb](0e3ebcb))
* **table:** Update multiple selection iconography
([#10125](#10125))

([f2b2016](f2b2016))
* **tooltip:** Allow focusing and clicking on interactive elements
within a tooltip
([#9914](#9914))

([a3c144c](a3c144c))


### Bug Fixes

* **accordion-item:** Align focus styles across browsers
([#9944](#9944))

([2e29b42](2e29b42))
* **alert:** Properly form a queue of alerts
([#10032](#10032))

([b24d6ac](b24d6ac))
* **color-picker:** Prevent text selection when using color
sliders/field
([#10043](#10043))

([ab33e4d](ab33e4d))
* **combobox, input-date-picker, input-number, input-text,
input-time-picker, input, radio-button-group, segmented-control, select,
text-area:** Use toAriaBoolean in aria-invalid attribute to provide
valid AT error messaging
([#10079](#10079))

([78bc096](78bc096))
* **combobox:** Update placeholder-icon color
([#9956](#9956))

([d916ca4](d916ca4))
* **dialog, flow-item:** Slotted closable panels should not close the
component
([#10130](#10130))

([ce2513d](ce2513d))
* **dialog:** Allow shell to be slotted inside
([#10118](#10118))

([ea3a6de](ea3a6de))
* **dialog:** Fix escapeDisabled when the escape key is pressed on the
panel
([#10097](#10097))

([9a5f1f1](9a5f1f1))
* Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit
properly
([#9958](#9958))

([7e2764f](7e2764f))
* **filter:** Fix setFocus method
([#10149](#10149))

([f4a959a](f4a959a))
* **input-date-picker:** Fix selection for the "bs" and "it-CH" locales
([#9976](#9976))

([368d9e2](368d9e2))
* **input-date-picker:** Prevent console error when using a lang
([#10162](#10162))

([e7bf604](e7bf604))
* **input-time-zone:** Translate region names
([#9940](#9940))

([f975adb](f975adb))
* **input, combobox, input-date-picker, input-number, input-text,
input-time-picker, radio-button-group, segmented-control, select,
text-area:** Provide clear field error messaging for AT
([#9880](#9880))

([46ad7d2](46ad7d2))
* **input, input-number, input-text:** No longer set focus when a
validation message is clicked
([#10008](#10008))

([529bb5a](529bb5a))
* **label:** Prevent focusing and toggling elements slotted within a
label when a text selection occurs
([#9990](#9990))

([49d6ae1](49d6ae1))
* **list-item:** Prevent scrolling when item is focused.
([#9948](#9948))

([eab1e06](eab1e06))
* **panel:** Define heading and description line height
([#10085](#10085))

([5478eb9](5478eb9))
* **slider:** Prevent text selection when using the slider
([#10073](#10073))

([04bf325](04bf325))
* **slider:** Resolve step & snap floating point precision
([#10148](#10148))

([613bc47](613bc47))
* **stepper-item:** Update component to take full width when parent's
layout is "vertical"
([#10009](#10009))

([03a5a30](03a5a30))
* **tree,tree-item:** Replace checkbox with div and a11y attributes
([#9849](#9849))

([b1ac951](b1ac951))


### Performance Improvements

* **input-time-zone:** Improve memory footprint by leveraging browser
cache and releasing utils after their use
([#9945](#9945))

([a3d2141](a3d2141))


### Reverts

* "build(deps): remove unused cheerio package
([#10049](#10049))"
([#10057](#10057))

([d271ab1](d271ab1))
* Add stories
([#10131](#10131))

([e3a6590](e3a6590))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.31.0-next.4 to 3.31.0
</details>

<details><summary>@esri/calcite-components-angular: 2.12.0</summary>

##

[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.1...@esri/calcite-components-angular@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

<details><summary>@esri/calcite-components-react: 2.12.0</summary>

##

[2.12.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.1...@esri/calcite-components-react@2.12.0)
(2024-08-28)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.0-next.34 to 2.12.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot]
<github-actions[bot]@users.noreply.github.com>

**Related Issue:** #

## Summary

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
driskull
driskull reviewed Sep 13, 2024
View reviewed changes
packages/calcite-components/src/components/combobox-item/combobox-item.tsx
* The component's text.
*
* @deprecated Use `heading` instead.
*/
@Prop({ reflect: true }) textLabel!: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textLabel should remove the ! so its no longer required here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull left review comments

@jcfranco jcfranco jcfranco approved these changes

Assignees

@aPreciado88 aPreciado88

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

Successfully merging this pull request may close these issues.
3 participants
@aPreciado88 @jcfranco @driskull