fix: subtitle file rename failure in collection #676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
#391
另外还有两个问题:
当字幕没有语种信息时([SumiSora][Tanakeda][02]x265_aac.ass)会命名失败,是否可将SubtitleFile.language类型改为Optional[str]?
关于非zh-tw|zh语种,因为语种信息一般是倒数第二个后缀(中二病也要谈恋爱! - S01E01 - 邂逅的…邪王真眼.jpn.ass),代码是否可以改为: