Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #22

Merged
merged 17 commits into from
Feb 22, 2021
Merged

Development #22

merged 17 commits into from
Feb 22, 2021

Conversation

EudyContreras
Copy link
Owner

@EudyContreras EudyContreras commented Feb 22, 2021

General Api improvements

Adresses issue #20

New view extensions and utility functions for toggling, enabling, disabling skeleton and bone loaders

fun View.enableSkeletonLoading() = this.toggleSkeletonLoading(true)
fun View.disableSkeletonLoading() = this.toggleSkeletonLoading(false)
fun View.toggleSkeletonLoading(enabled: Boolean)

We can now create SkeletonDrawables and BoneDrawables by passing properties and builders

fun create(view: View, enabled: Boolean = true, builder: BoneBuilder): BoneDrawable 
fun create(view: View, enabled: Boolean = true, properties: BoneProperties = BoneProperties()): BoneDrawable
fun builder(defaultProps: BoneProperties): BoneBuilder

fun create(viewGroup: ViewGroup, enabled: Boolean = true, builder: SkeletonBuilder): SkeletonDrawable
fun create(viewGroup: ViewGroup, enabled: Boolean = true, properties: SkeletonProperties = SkeletonProperties()): SkeletonDrawable
fun builder(defaultProps: SkeletonProperties = SkeletonProperties()): SkeletonBuilder

Missing builder functions for SkeletonBuilders

fun withBoneBuilder(view: View, builder: BoneBuilder.() -> Unit): SkeletonBuilder
fun setAnimateRestoreBounds(animateRestoreBounds: Boolean = false): SkeletonBuilder
fun withIgnoredBones(vararg ids: Int): SkeletonBuilder
fun withIgnoredBones(vararg views: View): SkeletonBuilder 

Missing builder properties for BoneBuilders

fun setCornerRadius(cornerRadius: Float = 0f): BoneBuilder

@EudyContreras EudyContreras self-assigned this Feb 22, 2021
@EudyContreras EudyContreras merged commit 68bcd2f into master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant