Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Debugger support #7

Merged
merged 7 commits into from
Nov 5, 2023
Merged

✨ Debugger support #7

merged 7 commits into from
Nov 5, 2023

Conversation

FurryR
Copy link
Contributor

@FurryR FurryR commented Nov 4, 2023

Updates

  • βœ… (Inspired by Gandi) Extension ESM support
  • πŸ” Full debugger (DevTool inspect) support
  • 🌟 (Zero delay, no need to wait 5 seconds) new trigger to get Blockly
  • πŸ₯‡ Some extra refactors

🚧 Implements #6.

Copy link
Member

@SimonShiki SimonShiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested

package.json Outdated Show resolved Hide resolved
src/loader/loader.ts Show resolved Hide resolved
src/loader/loader.ts Outdated Show resolved Hide resolved
src/loader/loader.ts Outdated Show resolved Hide resolved
src/loader/loader.ts Outdated Show resolved Hide resolved
src/injector/inject.ts Outdated Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
src/loader/loader.ts Show resolved Hide resolved
src/loader/loader.ts Outdated Show resolved Hide resolved
src/injector/inject.ts Outdated Show resolved Hide resolved
src/l10n/l10n.json Outdated Show resolved Hide resolved
src/l10n/l10n.json Outdated Show resolved Hide resolved
@SimonShiki
Copy link
Member

seems great. let me have a simple test

@SimonShiki SimonShiki merged commit f388054 into EurekaScratch:trunk Nov 5, 2023
1 check passed
@@ -9,6 +9,7 @@
"private": true,
"scripts": {
"build": "NODE_ENV=production webpack --color --bail",
"dev": "NODE_ENV=development webpack --color --bail",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider build:dev

// <reference path="./util/settings" />
/// <reference path="./loader/loader" />
/// <reference path="./loader/make-ctx" />
/// <reference path="./util/settings" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants