Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secure and cluster tests. #236

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

YoEight
Copy link
Member

@YoEight YoEight commented Aug 15, 2023

Changed: Add secure and cluster tests.

PR doesn't have as much changes as the diff suggests. Tests were re-organized so those can run regardless of the database topology:

  • Single node
  • Secure (still single node but with certificates configured)
  • Cluster (3 nodes)

Tests were almost gathered based on the scope of the ESDB api minus one caveat (Expectations):

  • Streams
  • Persistent Subscriptions.

Expectations tests are based on the image produced by the testdata repo. Those tests run a prepopulated database so we can test invariant behaviours across all clients. Those expectations tests are mostly reads operations including (persistent) subscriptions. There are projection tests too. Expectations tests do not run on a cluster, just single node setup.

Finally, this PR adds a dispatch action so we can test a specific server version manually. The version should match a version we deployed on our main repo docker registry.

@YoEight YoEight self-assigned this Aug 15, 2023
@linear
Copy link

linear bot commented Aug 15, 2023

DB-334 Improve Java client testing

We do not have tests running on a cluster for example.

@YoEight YoEight force-pushed the yoeight/db-334-improve-java-client-testing branch from 6f42a73 to f5f6825 Compare August 30, 2023 20:37
@YoEight YoEight changed the title Improve testing. Add secure and cluster tests. Aug 31, 2023
@YoEight YoEight marked this pull request as ready for review August 31, 2023 00:38
@YoEight YoEight force-pushed the yoeight/db-334-improve-java-client-testing branch from f5f6825 to 417cfef Compare August 31, 2023 00:51
@cdevarenne cdevarenne self-requested a review September 21, 2023 15:05
@YoEight YoEight marked this pull request as draft September 22, 2023 14:58
cdevarenne
cdevarenne previously approved these changes Sep 22, 2023
@cdevarenne cdevarenne self-requested a review September 22, 2023 21:59
@cdevarenne cdevarenne dismissed their stale review September 25, 2023 19:15

PR is still in draft

@YoEight YoEight force-pushed the yoeight/db-334-improve-java-client-testing branch from 7fd4471 to 4abf4b7 Compare September 26, 2023 00:05
@YoEight YoEight force-pushed the yoeight/db-334-improve-java-client-testing branch from 4abf4b7 to 1dcdfe1 Compare September 26, 2023 00:14
@YoEight YoEight marked this pull request as ready for review September 26, 2023 00:19
@YoEight YoEight merged commit cfb7b47 into trunk Oct 4, 2023
31 checks passed
@YoEight YoEight deleted the yoeight/db-334-improve-java-client-testing branch October 4, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants