Add getOptional to Http context #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
reviewed
Oct 27, 2017
There was a problem hiding this comment.
I would deprecate the old get() method. What do you think @kvosper @alobodzki ?
kvosper
reviewed
Oct 27, 2017
| @@ -57,6 +59,11 @@ public void add(String key, Object value) { | |||
| return null; | |||
| } | |||
| }; | |||
|
|
|||
| default <T> Optional<T> getOptional(String key, Class<T> clazz){ | |||
There was a problem hiding this comment.
I think we should use a name like getIfAvailable rather than getOptional, as it is better to describe the behaviour of the method rather than simply the return type, which is already visible.
There was a problem hiding this comment.
That's fine for me. I'll update w/ the change(and deprecation)
|
@mikkokar I agree with the deprecation. I have also added a comment to the file regarding the naming of the proposed new method. |
mikkokar
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.