-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styx load test script #18
Conversation
- Add missing LICENSE.txt - Add project version into base directory. - Add platform name into the zip file name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments left on files.
Makefile
Outdated
|
||
## Start with no origins (they can be launched separately if desired) | ||
start: release-styx | ||
APP_CONFIG_FILE_LOCATION=$(STYX_DEPLOY_FOLDER)/conf/$(STACK).yml \ | ||
APP_LOG_CONFIG_LOCATION=$(STYX_DEPLOY_FOLDER)/conf/logback/logback-$(STACK).xml $(STYX_DEPLOY_FOLDER)/bin/startup | ||
echo " - - - - - - - - - - - - - Running start-with-origins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message is not accurate.
$(STYX_HOME)/bin/startup \ | ||
-e $(CONFIG_ROOT)/styx-env.sh \ | ||
-l $(CONFIG_ROOT)/logback.xml \ | ||
$(CONFIG_ROOT)/styx-config.yml | ||
|
||
## Start with no origins (they can be launched separately if desired) | ||
start: release-styx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a warning "The requested profile "perf" could not be activated because it does not exist" when running this.
Makefile
Outdated
|
||
## Stops running netty-based origins (i.e. the origins started by start-origins) | ||
stop-origins: | ||
(support/origins-starter-app/bin/styx-originsstopper.sh 2>&1) | ||
|
||
## Starts netty-based origins (release-styx needs to have been run first) | ||
start-origins: stop-origins | ||
(support/origins-starter-app/bin/styx-originsstarter.sh $(STYX_HOME) $(STYX_DEPLOY_FOLDER)/conf/$(STACK).yml &) | ||
(support/origins-starter-app/bin/styx-originsstarter.sh $(STYX_HOME) $(CONFIG_ROOT)/styx-config.yml &) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running clean, start-origins fails. Can we make release-styx as prerequisite?
- Add release-styx prerequisite for start-origins. - Tidy up. Tidy up ExamplePluginFactory license header.
Add load test script to styx codebase. Usage:
Also fix a broken start-with-origins makefile recipe.