Simplify package structure for 1.0 styx-api module #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
requested review from
kvosper,
dvlato and
VivianLopes
and removed request for
kvosper
kvosper
suggested changes
Aug 23, 2018
| @@ -46,7 +40,7 @@ | |||
| */ | |||
| public abstract class AbstractStyxService implements StyxService { | |||
| private final String name; | |||
| private final AtomicReference<StyxServiceStatus> status = new AtomicReference<>(CREATED); | |||
| private final AtomicReference<StyxServiceStatus> status = new AtomicReference<>(StyxServiceStatus.CREATED); | |||
There was a problem hiding this comment.
Please reintroduce the static imports.
kvosper
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces number of java packages in styx-api module. Results in a more consistent and less cluttered API structure.
All HTTP message & interceptor related definitions are now in the
com.hotels.styx.apipackage.Any SPI extensions go under
com.hotels.styx.api.extension.<name>.spi. However to minimise impact on existing plugins the plugin definitions still live incom.hotels.styx.api.plugins.This PR also moves some unnecessary classes away from the API module.