Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#235 - Removed unused method #241

Merged
merged 6 commits into from
Sep 3, 2018
Merged

#235 - Removed unused method #241

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
659116c
removed unused isHttps method
VivianLopes Aug 22, 2018
6d6d29b
removed backendService constructor argument
VivianLopes Aug 23, 2018
ba1a5e9
changed applicationId to backendServiceId
VivianLopes Aug 24, 2018
4be1c51
replaced checkNonNull with requireNonNull
VivianLopes Aug 24, 2018
29a2156
Injected stickySessionConfig into StyxBackendServiceClientFactory, ad…
VivianLopes Aug 31, 2018
144dc45
fixed syntax error
VivianLopes Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changed applicationId to backendServiceId
  • Loading branch information
@VivianLopes
VivianLopes committed Aug 31, 2018
commit ba1a5e9a815b05f21d7af939e7dda1071d22453a
13 changes: 6 additions & 7 deletions components/client/src/main/java/com/hotels/styx/client/StyxHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public final class StyxHttpClient implements HttpClient {
private final StickySessionConfig stickySessionConfig;

private StyxHttpClient(Builder builder) {
this.id = requireNonNull(builder.applicationId);
this.id = requireNonNull(builder.backendServiceId);

this.stickySessionConfig = requireNonNull(builder.stickySessionConfig);

Expand Down Expand Up @@ -107,8 +107,8 @@ public Observable<HttpResponse> sendRequest(HttpRequest request) {
*
* @return a new builder
*/
public static Builder newHttpClientBuilder(Id applicationId) {
return new Builder(applicationId);
public static Builder newHttpClientBuilder(Id backendServiceId) {
return new Builder(backendServiceId);
}

private static boolean isError(HttpResponseStatus status) {
Expand Down Expand Up @@ -335,7 +335,7 @@ public String toString() {
*/
public static class Builder {

private final Id applicationId;
private final Id backendServiceId;
private MetricRegistry metricsRegistry = new CodaHaleMetricRegistry();
private List<RewriteRule> rewriteRules = emptyList();
private RetryPolicy retryPolicy = new RetryNTimes(3);
Expand All @@ -345,8 +345,8 @@ public static class Builder {
private String originsRestrictionCookieName;
private StickySessionConfig stickySessionConfig = stickySessionDisabled();

public Builder(Id applicationId) {
this.applicationId = requireNonNull(applicationId);
public Builder(Id backendServiceId) {
this.backendServiceId = requireNonNull(backendServiceId);
}

public Builder stickySessionConfig(StickySessionConfig stickySessionConfig) {
VivianLopes marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -397,6 +397,5 @@ public StyxHttpClient build() {
return new StyxHttpClient(this);
}


}
}