Streamline Styx HTTP Client interfaces #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
approved these changes
Sep 14, 2018
…terface would be removed, but it is used in several different unit tests to mock the BackendServiceClient.
…ent, and ClientEventLoopFactory classes from 'client.api' package to 'client' package.
mikkokar
force-pushed
the
styx-client
branch
from
d230f48
to
e0c9f47
Compare
kvosper
reviewed
Sep 14, 2018
| /** | ||
| * A configurable HTTP client that uses connection pooling, load balancing, etc. | ||
| */ | ||
| public final class StyxBackendServiceClient implements BackendServiceClient { |
There was a problem hiding this comment.
It would be nice if this class could be named BackendServiceClient, though that would obvious conflict with the interface name.
kvosper
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline Styx HTTP Client interfaces so that they can be published together with 1.0 API.
To sum up the changes:
The main HTTP client interfaces are moved into the
com.hotels.styx.clientpackage.The
StyxHttpClienthas been renamed toStyxBackendServiceClient. This is more descriptive, and it frees the more succinctStyxHttpClientto the more commonly usedFullHttpClient.The
FullHttpClientinterface is renamed toHttpClientwhich in the next iteration will be receiving a fluent interface to deal with both full and streaming HTTP requests, and to adjust contextual attributes per request basis.Note that there is no need
StyxBackendServiceClientneeds to implement any particular interface. TheBackendServiceClientinterface remains for now to simplify mocking in our unit tests.What do you think?
Does this renaming go too far or are there simpler approaches?