Refactor plugin loading #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
suggested changes
Feb 25, 2019
There was a problem hiding this comment.
Additionally to my comments, I believe the description of the PR doesn't make it clear what the relevant changes are or why it is needed. Since it's quite a big PR I guess it would make sense to provide some guidance to people checking differences between versions and similar. (as well as for people reviewing the code!)
components/proxy/src/main/java/com/hotels/styx/admin/handlers/PluginListHandler.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/proxy/plugin/NamedPlugin.java
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/proxy/plugin/PluginFactoriesLoader.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/StyxServerComponents.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/StyxServerComponents.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/StyxServerComponents.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/extensions/FailureHandling.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/extensions/FailureHandling.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/extensions/PluginLoadingForStartup.java
Outdated
Show resolved
Hide resolved
dvlato
suggested changes
Feb 25, 2019
components/proxy/src/main/java/com/hotels/styx/startup/extensions/ConfiguredPluginFactory.java
Outdated
Show resolved
Hide resolved
dvlato
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary focus of this PR is to decouple the Admin server from the plugin-loading, so that will be able to visit the admin server before the plugins have all been loaded.
That work is not totally finished by this PR (as it is already quite large and we don't want to add even more changes).
I have also taken the opportunity to tidy-up parts of the plugin-loading code that were messy.
It is a prerequisite to allowing Styx to have proper liveness/readiness checks, which needs the admin server to be able to start without waiting for the plugins.