Adding sections of pom requested by central repository #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
reviewed
Oct 18, 2017
pom.xml
Outdated
| </licenses> | ||
|
|
||
| <scm> | ||
| <connection>scm:git:git://github.com/netty/netty.git</connection> |
There was a problem hiding this comment.
Is this reference to a netty git repository intentional?
alobodzki
force-pushed
the
maven-repository-pom-settings
branch
2 times, most recently
from
2fcbbb0
to
7f65f2f
Compare
massdosage
reviewed
Oct 19, 2017
pom.xml
Outdated
|
|
||
| <scm> | ||
| <connection>scm:git:git@github.com:HotelsDotCom/styx.git</connection> | ||
| <developerConnection>scm:git:ssh://git@github.com:HotelsDotCom/styx.git</developerConnection> |
There was a problem hiding this comment.
Why does this have "ssh" in it but the normal connection doesn't? I think this could just be the same "scm:git:git@github.com:HotelsDotCom/styx.git". This is what we have in WaggleDance which pushes artifacts to Sonatype.
alobodzki
force-pushed
the
maven-repository-pom-settings
branch
from
7f65f2f
to
03e95f9
Compare
mikkokar
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.