Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy up python dependencies #19

Closed
wants to merge 1 commit into from
Closed

tidy up python dependencies #19

wants to merge 1 commit into from

Conversation

guillomovitch
Copy link

  • bs4 is just a wrapper for beautifulsoup4
  • http_client seems unused anywhere
  • pathlib and ipaddress are python2 backports of python3 modules

@guillomovitch
tidy up python dependencies
e01de3e 
- bs4 is just a wrapper for beautifulsoup4
- http_client seems unused anywhere
- pathlib and ipaddress are python2 backports of python3 modules
@guillomovitch
Copy link
Author

As explained in the commit changelog, most of these dependencies are either useless, or indirect. It doesn't hurt for people managing dependencies manually, with pip for instance, but it does for linux distribution package maintainers, where those dependencies triggers automatic dependencies that would in turn need useless additional package creation in order to get satisfied.

@warburtr0n warburtr0n self-requested a review January 18, 2021 12:49
@warburtr0n warburtr0n added the enhancement New feature or request label Jan 18, 2021
@guillomovitch
Copy link
Author

Obsoleted by PR#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warburtr0n warburtr0n Awaiting requested review from warburtr0n

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guillomovitch @warburtr0n