Skip to content

Commit

Permalink
*: Convert THREAD_XXX macros to EVENT_XXX macros
Browse files Browse the repository at this point in the history
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
  • Loading branch information
donaldsharp committed Mar 24, 2023
1 parent 70d4d90 commit e16d030
Show file tree
Hide file tree
Showing 191 changed files with 1,243 additions and 1,248 deletions.
20 changes: 10 additions & 10 deletions bfdd/bfd.c
Original file line number Diff line number Diff line change
Expand Up @@ -620,14 +620,14 @@ struct bfd_session *ptm_bfd_sess_find(struct bfd_pkt *cp,

void bfd_xmt_cb(struct event *t)
{
struct bfd_session *bs = THREAD_ARG(t);
struct bfd_session *bs = EVENT_ARG(t);

ptm_bfd_xmt_TO(bs, 0);
}

void bfd_echo_xmt_cb(struct event *t)
{
struct bfd_session *bs = THREAD_ARG(t);
struct bfd_session *bs = EVENT_ARG(t);

if (bs->echo_xmt_TO > 0)
ptm_bfd_echo_xmt_TO(bs);
Expand All @@ -636,7 +636,7 @@ void bfd_echo_xmt_cb(struct event *t)
/* Was ptm_bfd_detect_TO() */
void bfd_recvtimer_cb(struct event *t)
{
struct bfd_session *bs = THREAD_ARG(t);
struct bfd_session *bs = EVENT_ARG(t);

switch (bs->ses_state) {
case PTM_BFD_INIT:
Expand All @@ -649,7 +649,7 @@ void bfd_recvtimer_cb(struct event *t)
/* Was ptm_bfd_echo_detect_TO() */
void bfd_echo_recvtimer_cb(struct event *t)
{
struct bfd_session *bs = THREAD_ARG(t);
struct bfd_session *bs = EVENT_ARG(t);

switch (bs->ses_state) {
case PTM_BFD_INIT:
Expand Down Expand Up @@ -1999,12 +1999,12 @@ static int bfd_vrf_disable(struct vrf *vrf)
zlog_debug("VRF disable %s id %d", vrf->name, vrf->vrf_id);

/* Disable read/write poll triggering. */
THREAD_OFF(bvrf->bg_ev[0]);
THREAD_OFF(bvrf->bg_ev[1]);
THREAD_OFF(bvrf->bg_ev[2]);
THREAD_OFF(bvrf->bg_ev[3]);
THREAD_OFF(bvrf->bg_ev[4]);
THREAD_OFF(bvrf->bg_ev[5]);
EVENT_OFF(bvrf->bg_ev[0]);
EVENT_OFF(bvrf->bg_ev[1]);
EVENT_OFF(bvrf->bg_ev[2]);
EVENT_OFF(bvrf->bg_ev[3]);
EVENT_OFF(bvrf->bg_ev[4]);
EVENT_OFF(bvrf->bg_ev[5]);

/* Close all descriptors. */
socket_close(&bvrf->bg_echo);
Expand Down
16 changes: 8 additions & 8 deletions bfdd/bfd_packet.c
Original file line number Diff line number Diff line change
Expand Up @@ -701,27 +701,27 @@ ssize_t bfd_recv_ipv6(int sd, uint8_t *msgbuf, size_t msgbuflen, uint8_t *ttl,
static void bfd_sd_reschedule(struct bfd_vrf_global *bvrf, int sd)
{
if (sd == bvrf->bg_shop) {
THREAD_OFF(bvrf->bg_ev[0]);
EVENT_OFF(bvrf->bg_ev[0]);
event_add_read(master, bfd_recv_cb, bvrf, bvrf->bg_shop,
&bvrf->bg_ev[0]);
} else if (sd == bvrf->bg_mhop) {
THREAD_OFF(bvrf->bg_ev[1]);
EVENT_OFF(bvrf->bg_ev[1]);
event_add_read(master, bfd_recv_cb, bvrf, bvrf->bg_mhop,
&bvrf->bg_ev[1]);
} else if (sd == bvrf->bg_shop6) {
THREAD_OFF(bvrf->bg_ev[2]);
EVENT_OFF(bvrf->bg_ev[2]);
event_add_read(master, bfd_recv_cb, bvrf, bvrf->bg_shop6,
&bvrf->bg_ev[2]);
} else if (sd == bvrf->bg_mhop6) {
THREAD_OFF(bvrf->bg_ev[3]);
EVENT_OFF(bvrf->bg_ev[3]);
event_add_read(master, bfd_recv_cb, bvrf, bvrf->bg_mhop6,
&bvrf->bg_ev[3]);
} else if (sd == bvrf->bg_echo) {
THREAD_OFF(bvrf->bg_ev[4]);
EVENT_OFF(bvrf->bg_ev[4]);
event_add_read(master, bfd_recv_cb, bvrf, bvrf->bg_echo,
&bvrf->bg_ev[4]);
} else if (sd == bvrf->bg_echov6) {
THREAD_OFF(bvrf->bg_ev[5]);
EVENT_OFF(bvrf->bg_ev[5]);
event_add_read(master, bfd_recv_cb, bvrf, bvrf->bg_echov6,
&bvrf->bg_ev[5]);
}
Expand Down Expand Up @@ -770,7 +770,7 @@ static void cp_debug(bool mhop, struct sockaddr_any *peer,

void bfd_recv_cb(struct event *t)
{
int sd = THREAD_FD(t);
int sd = EVENT_FD(t);
struct bfd_session *bfd;
struct bfd_pkt *cp;
bool is_mhop;
Expand All @@ -781,7 +781,7 @@ void bfd_recv_cb(struct event *t)
struct sockaddr_any local, peer;
uint8_t msgbuf[1516];
struct interface *ifp = NULL;
struct bfd_vrf_global *bvrf = THREAD_ARG(t);
struct bfd_vrf_global *bvrf = EVENT_ARG(t);

/* Schedule next read. */
bfd_sd_reschedule(bvrf, sd);
Expand Down
6 changes: 3 additions & 3 deletions bfdd/control.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ void control_shutdown(void)

void control_accept(struct event *t)
{
int csock, sd = THREAD_FD(t);
int csock, sd = EVENT_FD(t);

csock = accept(sd, NULL, 0);
if (csock == -1) {
Expand Down Expand Up @@ -381,7 +381,7 @@ static void control_reset_buf(struct bfd_control_buffer *bcb)

static void control_read(struct event *t)
{
struct bfd_control_socket *bcs = THREAD_ARG(t);
struct bfd_control_socket *bcs = EVENT_ARG(t);
struct bfd_control_buffer *bcb = &bcs->bcs_bin;
int sd = bcs->bcs_sd;
struct bfd_control_msg bcm;
Expand Down Expand Up @@ -516,7 +516,7 @@ static void control_read(struct event *t)

static void control_write(struct event *t)
{
struct bfd_control_socket *bcs = THREAD_ARG(t);
struct bfd_control_socket *bcs = EVENT_ARG(t);
struct bfd_control_buffer *bcb = bcs->bcs_bout;
int sd = bcs->bcs_sd;
ssize_t bwrite;
Expand Down
26 changes: 13 additions & 13 deletions bfdd/dplane.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,14 +307,14 @@ static ssize_t bfd_dplane_flush(struct bfd_dplane_ctx *bdc)
stream_pulldown(bdc->outbuf);

/* Disable write ready events. */
THREAD_OFF(bdc->outbufev);
EVENT_OFF(bdc->outbufev);

return total;
}

static void bfd_dplane_write(struct event *t)
{
struct bfd_dplane_ctx *bdc = THREAD_ARG(t);
struct bfd_dplane_ctx *bdc = EVENT_ARG(t);

/* Handle connection stage. */
if (bdc->connecting && bfd_dplane_client_connecting(bdc))
Expand Down Expand Up @@ -601,7 +601,7 @@ static int bfd_dplane_expect(struct bfd_dplane_ctx *bdc, uint16_t id,

static void bfd_dplane_read(struct event *t)
{
struct bfd_dplane_ctx *bdc = THREAD_ARG(t);
struct bfd_dplane_ctx *bdc = EVENT_ARG(t);
int rv;

rv = bfd_dplane_expect(bdc, 0, bfd_dplane_handle_message, NULL);
Expand Down Expand Up @@ -672,16 +672,16 @@ static void bfd_dplane_ctx_free(struct bfd_dplane_ctx *bdc)
/* Client mode has special treatment. */
if (bdc->client) {
/* Disable connection event if any. */
THREAD_OFF(bdc->connectev);
EVENT_OFF(bdc->connectev);

/* Normal treatment on shutdown. */
if (bglobal.bg_shutdown)
goto free_resources;

/* Attempt reconnection. */
socket_close(&bdc->sock);
THREAD_OFF(bdc->inbufev);
THREAD_OFF(bdc->outbufev);
EVENT_OFF(bdc->inbufev);
EVENT_OFF(bdc->outbufev);
event_add_timer(master, bfd_dplane_client_connect, bdc, 3,
&bdc->connectev);
return;
Expand All @@ -699,8 +699,8 @@ static void bfd_dplane_ctx_free(struct bfd_dplane_ctx *bdc)
socket_close(&bdc->sock);
stream_free(bdc->inbuf);
stream_free(bdc->outbuf);
THREAD_OFF(bdc->inbufev);
THREAD_OFF(bdc->outbufev);
EVENT_OFF(bdc->inbufev);
EVENT_OFF(bdc->outbufev);
XFREE(MTYPE_BFDD_DPLANE_CTX, bdc);
}

Expand Down Expand Up @@ -821,7 +821,7 @@ static uint16_t bfd_dplane_request_counters(const struct bfd_session *bs)
*/
static void bfd_dplane_accept(struct event *t)
{
struct bfd_global *bg = THREAD_ARG(t);
struct bfd_global *bg = EVENT_ARG(t);
struct bfd_dplane_ctx *bdc;
int sock;

Expand Down Expand Up @@ -901,7 +901,7 @@ static bool bfd_dplane_client_connecting(struct bfd_dplane_ctx *bdc)

static void bfd_dplane_client_connect(struct event *t)
{
struct bfd_dplane_ctx *bdc = THREAD_ARG(t);
struct bfd_dplane_ctx *bdc = EVENT_ARG(t);
int rv, sock;
socklen_t rvlen = sizeof(rv);

Expand Down Expand Up @@ -949,8 +949,8 @@ static void bfd_dplane_client_connect(struct event *t)
}

reschedule_connect:
THREAD_OFF(bdc->inbufev);
THREAD_OFF(bdc->outbufev);
EVENT_OFF(bdc->inbufev);
EVENT_OFF(bdc->outbufev);
socket_close(&sock);
event_add_timer(master, bfd_dplane_client_connect, bdc, 3,
&bdc->connectev);
Expand Down Expand Up @@ -997,7 +997,7 @@ static int bfd_dplane_finish_late(void)
bfd_dplane_ctx_free(bdc);

/* Cancel accept thread and close socket. */
THREAD_OFF(bglobal.bg_dplane_sockev);
EVENT_OFF(bglobal.bg_dplane_sockev);
close(bglobal.bg_dplane_sock);

return 0;
Expand Down
8 changes: 4 additions & 4 deletions bfdd/event.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,20 @@ void bfd_echo_xmttimer_update(struct bfd_session *bs, uint64_t jitter)

void bfd_recvtimer_delete(struct bfd_session *bs)
{
THREAD_OFF(bs->recvtimer_ev);
EVENT_OFF(bs->recvtimer_ev);
}

void bfd_echo_recvtimer_delete(struct bfd_session *bs)
{
THREAD_OFF(bs->echo_recvtimer_ev);
EVENT_OFF(bs->echo_recvtimer_ev);
}

void bfd_xmttimer_delete(struct bfd_session *bs)
{
THREAD_OFF(bs->xmttimer_ev);
EVENT_OFF(bs->xmttimer_ev);
}

void bfd_echo_xmttimer_delete(struct bfd_session *bs)
{
THREAD_OFF(bs->echo_xmttimer_ev);
EVENT_OFF(bs->echo_xmttimer_ev);
}
36 changes: 18 additions & 18 deletions bgpd/bgp_bmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,7 @@ static void bmp_stat_put_u32(struct stream *s, size_t *cnt, uint16_t type,

static void bmp_stats(struct event *thread)
{
struct bmp_targets *bt = THREAD_ARG(thread);
struct bmp_targets *bt = EVENT_ARG(thread);
struct stream *s;
struct peer *peer;
struct listnode *node;
Expand Down Expand Up @@ -1390,7 +1390,7 @@ static void bmp_stats(struct event *thread)
/* read from the BMP socket to detect session termination */
static void bmp_read(struct event *t)
{
struct bmp *bmp = THREAD_ARG(t);
struct bmp *bmp = EVENT_ARG(t);
char buf[1024];
ssize_t n;

Expand Down Expand Up @@ -1495,7 +1495,7 @@ static struct bmp *bmp_open(struct bmp_targets *bt, int bmp_sock)
static void bmp_accept(struct event *thread)
{
union sockunion su;
struct bmp_listener *bl = THREAD_ARG(thread);
struct bmp_listener *bl = EVENT_ARG(thread);
int bmp_sock;

/* We continue hearing BMP socket. */
Expand All @@ -1517,7 +1517,7 @@ static void bmp_close(struct bmp *bmp)
struct bmp_queue_entry *bqe;
struct bmp_mirrorq *bmq;

THREAD_OFF(bmp->t_read);
EVENT_OFF(bmp->t_read);

if (bmp->active)
bmp_active_disconnected(bmp->active);
Expand All @@ -1529,7 +1529,7 @@ static void bmp_close(struct bmp *bmp)
if (!bqe->refcount)
XFREE(MTYPE_BMP_QUEUE, bqe);

THREAD_OFF(bmp->t_read);
EVENT_OFF(bmp->t_read);
pullwr_del(bmp->pullwr);
close(bmp->socket);
}
Expand Down Expand Up @@ -1644,7 +1644,7 @@ static void bmp_targets_put(struct bmp_targets *bt)
struct bmp *bmp;
struct bmp_active *ba;

THREAD_OFF(bt->t_stats);
EVENT_OFF(bt->t_stats);

frr_each_safe (bmp_actives, &bt->actives, ba)
bmp_active_put(ba);
Expand Down Expand Up @@ -1729,7 +1729,7 @@ static void bmp_listener_start(struct bmp_listener *bl)

static void bmp_listener_stop(struct bmp_listener *bl)
{
THREAD_OFF(bl->t_accept);
EVENT_OFF(bl->t_accept);

if (bl->sock != -1)
close(bl->sock);
Expand Down Expand Up @@ -1768,9 +1768,9 @@ static struct bmp_active *bmp_active_get(struct bmp_targets *bt,

static void bmp_active_put(struct bmp_active *ba)
{
THREAD_OFF(ba->t_timer);
THREAD_OFF(ba->t_read);
THREAD_OFF(ba->t_write);
EVENT_OFF(ba->t_timer);
EVENT_OFF(ba->t_read);
EVENT_OFF(ba->t_write);

bmp_actives_del(&ba->targets->actives, ba);

Expand Down Expand Up @@ -1904,16 +1904,16 @@ static void bmp_active_resolved(struct resolver_query *resq, const char *errstr,

static void bmp_active_thread(struct event *t)
{
struct bmp_active *ba = THREAD_ARG(t);
struct bmp_active *ba = EVENT_ARG(t);
socklen_t slen;
int status, ret;
vrf_id_t vrf_id;

/* all 3 end up here, though only timer or read+write are active
* at a time */
THREAD_OFF(ba->t_timer);
THREAD_OFF(ba->t_read);
THREAD_OFF(ba->t_write);
EVENT_OFF(ba->t_timer);
EVENT_OFF(ba->t_read);
EVENT_OFF(ba->t_write);

ba->last_err = NULL;

Expand Down Expand Up @@ -1967,9 +1967,9 @@ static void bmp_active_disconnected(struct bmp_active *ba)

static void bmp_active_setup(struct bmp_active *ba)
{
THREAD_OFF(ba->t_timer);
THREAD_OFF(ba->t_read);
THREAD_OFF(ba->t_write);
EVENT_OFF(ba->t_timer);
EVENT_OFF(ba->t_read);
EVENT_OFF(ba->t_write);

if (ba->bmp)
return;
Expand Down Expand Up @@ -2190,7 +2190,7 @@ DEFPY(bmp_stats_cfg,
{
VTY_DECLVAR_CONTEXT_SUB(bmp_targets, bt);

THREAD_OFF(bt->t_stats);
EVENT_OFF(bt->t_stats);
if (no)
bt->stat_msec = 0;
else if (interval_str)
Expand Down
4 changes: 2 additions & 2 deletions bgpd/bgp_conditional_adv.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ static void bgp_conditional_adv_timer(struct event *t)
route_map_result_t ret;
bool advmap_table_changed = false;

bgp = THREAD_ARG(t);
bgp = EVENT_ARG(t);
assert(bgp);

event_add_timer(bm->master, bgp_conditional_adv_timer, bgp,
Expand Down Expand Up @@ -351,7 +351,7 @@ void bgp_conditional_adv_disable(struct peer *peer, afi_t afi, safi_t safi)
}

/* Last filter removed. So cancel conditional routes polling thread. */
THREAD_OFF(bgp->t_condition_check);
EVENT_OFF(bgp->t_condition_check);
}

static void peer_advertise_map_filter_update(struct peer *peer, afi_t afi,
Expand Down
Loading

0 comments on commit e16d030

Please sign in to comment.