ldpd: fix ACL rule modification #6241

lynne-volta · 2020-04-16T13:46:30Z

Changes to ACL rules were not applied to LDP.  This fix allows
LDP to be notified when a rule in an ACL filter is modified by
the user. The filter is properly applied to the LDP session.
The filter may cause a LDP session to go down/up or to remove/add
labels being advertised/received from a neighbor.

Signed-off-by: Lynne Morrison <lynne@voltanet.io>
Signed-off-by: Karen Schoener <karen@voltanet.io>

NetDEF-CI · 2020-04-16T14:08:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c: In function 'ldp_zebra_filter_update':
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: 'ldp_zebra_filter_update_del' declared 'static' but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/U1804AMD64/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI001BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory `/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory `/home/ci/cibuild.11907/frr-source'
make[1]: Target `all-am' not remade because of errors.
make: *** [all] Error 2

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI001BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI008BLD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7177: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11907/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/U1804PPC64LEBUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI021BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11907/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI021BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c:48:14: error: unused function 'ldp_zebra_filter_update_del' [-Werror,-Wunused-function]
static void      ldp_zebra_filter_update_del(struct access_list *access);
1 error generated.
gmake[1]: *** [Makefile:7665: ldpd/ldp_zebra.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.11907/frr-source'
gmake: *** [Makefile:4561: all] Error 2

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c: In function 'ldp_zebra_filter_update':
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: 'ldp_zebra_filter_update_del' declared 'static' but never defined [-Werror=unused-function]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI009BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI012BUILD/ErrorLog/log_make.txt)

/usr/pkg/lib/libpython2.7.so: warning: warning: tmpnam() possibly used unsafely, use mkstemp() or mkdtemp()
/usr/pkg/lib/libpython2.7.so: warning: warning: tempnam() possibly used unsafely, use mkstemp() or mkdtemp()
ldpd/ldp_zebra.c:48:14: error: 'ldp_zebra_filter_update_del' declared 'static' but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.11907/frr-source'

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI014BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11907/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/CI014BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/U1604I386/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11907/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11907/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7667: ldpd/ldp_zebra.o] Error 1

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11907/artifact/DEB10BUILD/config.status/config.status

Successful on other platforms/tests

CentOS 7 amd64 build
Ubuntu 12.04 amd64 build

NetDEF-CI · 2020-04-16T14:13:44Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c: In function 'ldp_zebra_filter_update':
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: 'ldp_zebra_filter_update_del' declared 'static' but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/U1804AMD64/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI001BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory `/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory `/home/ci/cibuild.11908/frr-source'
make[1]: Target `all-am' not remade because of errors.
make: *** [all] Error 2

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI001BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/U1604I386/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11908/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/U1604I386/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI008BLD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7177: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11908/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI008BLD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI021BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11908/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI021BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c: In function 'ldp_zebra_filter_update':
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: 'ldp_zebra_filter_update_del' declared 'static' but never defined [-Werror=unused-function]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/U1804PPC64LEBUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c:48:14: error: unused function 'ldp_zebra_filter_update_del' [-Werror,-Wunused-function]
static void      ldp_zebra_filter_update_del(struct access_list *access);
1 error generated.
gmake[1]: *** [Makefile:7665: ldpd/ldp_zebra.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.11908/frr-source'
gmake: *** [Makefile:4561: all] Error 2

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI012BUILD/ErrorLog/log_make.txt)

/usr/pkg/lib/libpython2.7.so: warning: warning: tmpnam() possibly used unsafely, use mkstemp() or mkdtemp()
/usr/pkg/lib/libpython2.7.so: warning: warning: tempnam() possibly used unsafely, use mkstemp() or mkdtemp()
ldpd/ldp_zebra.c:48:14: error: 'ldp_zebra_filter_update_del' declared 'static' but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
gmake[1]: Leaving directory '/home/ci/cibuild.11908/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI014BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
Makefile:7190: recipe for target 'ldpd/ldp_zebra.o' failed
make[1]: *** [ldpd/ldp_zebra.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.11908/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/CI014BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7667: ldpd/ldp_zebra.o] Error 1

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/DEB10BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.11908/frr-source'
ldpd/ldp_zebra.c: In function ldp_zebra_filter_update:
ldpd/ldp_zebra.c:525:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
ldpd/ldp_zebra.c:525:6: note: did you mean to dereference the pointer?
ldpd/ldp_zebra.c: At top level:
ldpd/ldp_zebra.c:48:14: error: ldp_zebra_filter_update_del declared static but never defined [-Werror=unused-function]
 static void  ldp_zebra_filter_update_del(struct access_list *access);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7666: ldpd/ldp_zebra.o] Error 1

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11908/artifact/F29BUILD/config.status/config.status

Successful on other platforms/tests

CentOS 7 amd64 build
Ubuntu 12.04 amd64 build

LabN-CI · 2020-04-16T15:53:39Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6241 `92c70fd`
Date	04/16/2020
Start	11:27:40
Finish	11:53:34
Run-Time	25:54
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-16-11:27:40.txt
Log	autoscript-2020-04-16-11:28:37.log.bz2
Memory	484 421 426

For details, please contact louberger

NetDEF-CI · 2020-04-16T17:57:43Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11914/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11914/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-gac4b4d668-0 (missing) -> 7.4-dev-20200416-00-gac4b4d668-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-gac4b4d668-0 (missing) -> 7.4-dev-20200416-00-gac4b4d668-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-gac4b4d668-0 (missing) -> 7.4-dev-20200416-00-gac4b4d668-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-gac4b4d668-0 (missing) -> 7.4-dev-20200416-00-gac4b4d668-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-gac4b4d668-0 (missing) -> 7.4-dev-20200416-00-gac4b4d668-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6241, comparing to Git base SHA 09133ff
Base image data for Git 09133ff does not exist - compare skipped

2 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11914/artifact/shared/static_analysis/index.html

LabN-CI · 2020-04-16T18:08:56Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6241 `ac4b4d6`
Date	04/16/2020
Start	13:42:56
Finish	14:08:50
Run-Time	25:54
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-16-13:42:56.txt
Log	autoscript-2020-04-16-13:43:52.log.bz2
Memory	495 463 429

For details, please contact louberger

LabN-CI · 2020-04-16T19:31:21Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6241 `6a158af`
Date	04/16/2020
Start	15:05:27
Finish	15:31:15
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-16-15:05:27.txt
Log	autoscript-2020-04-16-15:06:23.log.bz2
Memory	468 494 426

For details, please contact louberger

NetDEF-CI · 2020-04-16T19:58:53Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11919/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11919/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2020-04-16 19:00:18,718 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/bgp.py", line 159, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 4: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-04-16 19:00:18,947 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/bgp.py", line 159, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp 



*** defaultIntf: warning: r1 has no interfaces
2020-04-16 19:27:05,728 ERROR: '_bgp_has_routes' failed after 37.31 seconds
2020-04-16 19:29:59,378 ERROR: ******************************************************************************
2020-04-16 19:29:59,378 ERROR: Test Target Summary                                                  Pass Fail
2020-04-16 19:29:59,378 ERROR: ******************************************************************************
2020-04-16 19:29:59,378 ERROR: FILE: scripts/adjacencies.py
2020-04-16 19:29:59,378 ERROR: 15   r3     All adjacencies up                                       0    1
2020-04-16 19:29:59,378 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/output.log for details of errors
2020-04-16 19:29:59,379 ERROR: assert failed at "bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/test_adjacencies": 1 tests failed
2020-04-16 19:34:15,066 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-04-16 19:34:15,185 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-04-16 19:34:15,304 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-04-16 19:34:15,422 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-04-16 19:36:11,194 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2020-04-16 19:43:04,174 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-04-16 19:43:06,232 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-04-16 19:43:12,388 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11919/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotest tests on Ubuntu 16.04 i386
Addresssanitizer topotests part 2
Debian 10 deb pkg check
Ubuntu 14.04 deb pkg check
IPv4 ldp protocol on Ubuntu 16.04
Addresssanitizer topotests part 3
CentOS 7 rpm pkg check
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 14.04
Topology tests on Ubuntu 16.04 amd64
Debian 9 deb pkg check
Ubuntu 12.04 deb pkg check
Fedora 29 rpm pkg check
Static analyzer (clang)
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 14.04
Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11919/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g6a158af6a-0 (missing) -> 7.4-dev-20200416-00-g6a158af6a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g6a158af6a-0 (missing) -> 7.4-dev-20200416-00-g6a158af6a-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g6a158af6a-0 (missing) -> 7.4-dev-20200416-00-g6a158af6a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g6a158af6a-0 (missing) -> 7.4-dev-20200416-00-g6a158af6a-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g6a158af6a-0 (missing) -> 7.4-dev-20200416-00-g6a158af6a-0~deb10u1

qlyoung · 2020-04-16T20:32:34Z

ldpd/ldp_zebra.c

+	struct ldp_access laccess;
+
+	if (access && access->name[0] != '\0') {
+		strlcpy(laccess.name,access->name, sizeof(laccess.name));


space after that comma?

NetDEF-CI · 2020-04-16T21:11:15Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11922/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11922/artifact/CI011BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
_________________________ TestMpath.test_exit_cleanly __________________________
self = <test_mpath.TestMpath object at 0x9b755717470>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:57: in reraise
    raise value
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_mpath.TestMpath object at 0x9b755717470>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           frrtest.MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:84: MultiTestFailure
----------------------------- Captured stderr call -----------------------------
2020/04/16 13:58:31 unknown: [EC 100663299] buffer_write: write error on fd 0: Bad file descriptor
2020/04/16 13:58:31 unknown: [EC 100663302] zclient_send_message: buffer_write failed to zclient fd 0, closing
___________________ TestMpath.test_bgp_maximum_paths_config ____________________
self = <test_mpath.TestMpath object at 0x9b75500ed30>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:57: in reraise
    raise value
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_mpath.TestMpath object at 0x9b755717470>
line = b'bgp maximum-paths config'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'bgp maximum-paths config' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
__________________________ TestMpath.test_bgp_mp_list __________________________
self = <test_mpath.TestMpath object at 0x9b7550029b0>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:57: in reraise
    raise value
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_mpath.TestMpath object at 0x9b755717470>, line = b'bgp_mp_list'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'bgp_mp_list' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
__________________ TestMpath.test_bgp_path_info_mpath_update ___________________
self = <test_mpath.TestMpath object at 0x9b7557177f0>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:57: in reraise
    raise value
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11922/artifact/CI011BUILD/config.status/config.status

Successful on other platforms/tests

Ubuntu 12.04 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Debian 10 amd64 build
FreeBSD 12 amd64 build
CentOS 7 amd64 build
Ubuntu 18.04 amd64 build
Ubuntu 14.04 amd64 build
Debian 8 amd64 build
Ubuntu 18.04 ppc64le build
Debian 9 amd64 build
NetBSD 8 amd64 build
FreeBSD 11 amd64 build
Ubuntu 16.04 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11922/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g9ff90e8f0-0 (missing) -> 7.4-dev-20200416-00-g9ff90e8f0-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g9ff90e8f0-0 (missing) -> 7.4-dev-20200416-00-g9ff90e8f0-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g9ff90e8f0-0 (missing) -> 7.4-dev-20200416-00-g9ff90e8f0-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g9ff90e8f0-0 (missing) -> 7.4-dev-20200416-00-g9ff90e8f0-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200416-00-g9ff90e8f0-0 (missing) -> 7.4-dev-20200416-00-g9ff90e8f0-0~deb10u1

LabN-CI · 2020-04-16T21:22:28Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6241 `9ff90e8`
Date	04/16/2020
Start	16:56:32
Finish	17:22:22
Run-Time	25:50
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-16-16:56:32.txt
Log	autoscript-2020-04-16-16:57:30.log.bz2
Memory	483 459 424

For details, please contact louberger

LabN-CI · 2020-04-17T12:56:23Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6241 `5fc5288`
Date	04/17/2020
Start	08:30:27
Finish	08:56:18
Run-Time	25:51
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-17-08:30:27.txt
Log	autoscript-2020-04-17-08:31:23.log.bz2
Memory	483 489 427

For details, please contact louberger

NetDEF-CI · 2020-04-17T13:58:58Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11928/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11928/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-00-g5fc52884f-0 (missing) -> 7.4-dev-20200417-00-g5fc52884f-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-00-g5fc52884f-0 (missing) -> 7.4-dev-20200417-00-g5fc52884f-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-00-g5fc52884f-0 (missing) -> 7.4-dev-20200417-00-g5fc52884f-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-00-g5fc52884f-0 (missing) -> 7.4-dev-20200417-00-g5fc52884f-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-00-g5fc52884f-0 (missing) -> 7.4-dev-20200417-00-g5fc52884f-0~deb10u1

riw777 · 2020-04-21T15:12:40Z

ldpd/lde.c

+				return;
+			break;
+		default:
+			fatalx("lde_send_labelrequest: unknown af");


This looks like it just crashes out -- should we crash here, or just print an error/log and ignore this input? Just wondering about this being the right result here.

The way this function is coded matches the rest of the LDP code. I will leave it up to Renato if wants me to change this code.

I think this is fine. This kind of error would correspond to an internal inconsistency that isn't worth trying to recover from.

rwestphal

Thanks for doing this work. Overall this looks good to me, but there are a few issues that need to be fixed. Please see my inline comments.

rwestphal · 2020-04-24T00:18:55Z

ldpd/lde.c

+				AF_INET,
+				(union ldpd_addr *)&fn->fec.u.ipv4.prefix,
+				fn->fec.u.ipv4.prefixlen) != FILTER_PERMIT)
+				return;


I think these ACL checks don't belong here, since we're requesting labels and not advertising them. None of the existing filters apply to outgoing label requests.

rwestphal · 2020-04-24T00:21:34Z

ldpd/lde.c

+
+	if (single)
+		lde_imsg_compose_ldpe(IMSG_REQUEST_ADD_END,
+		       ln->peerid, 0, NULL, 0);


nit: second level indents are four spaces in the BSD coding style (please review the entire commit to fix all instances of this issue).

rwestphal · 2020-04-24T00:23:48Z

ldpd/lde.c

+
+	map.label = NO_LABEL;
+
+	/* SLRq.3: send label request */


Please implement step SLRq.1 as well (let's ignore SLRq.2 for now).

rwestphal · 2020-04-24T00:24:04Z

ldpd/lde.c

+				lde_req_add(ln, f, 1);
+		}
+	}
+


nit: redundant newline

rwestphal · 2020-04-24T00:28:13Z

ldpd/lde.c

+	struct map	 wcard;
+
+	memset(&wcard, 0, sizeof(wcard));
+	wcard.type = MAP_TYPE_TYPED_WCARD;


A typed wildcard can only be sent to neighbors that advertised this capability during the session initialization. When that's not the case, doing a full wildcard request (MAP_TYPE_WILDCARD) should be okay.

I thought in RFC 5036 that wildcard could only be used for labelwithdraw and labelrelease.
In RFC 5918 labelrequest wild card was added and is only supported with this typed wildcard. But I'm probably missing something here in the RFC

You're right. It this case it seems the only option is to reset the neighborships as we discussed before.

I'm assuming the correct behavior here is for lde process to send a message to ldpe and then in ldpe call
session_shutdown(nbr, S_SHUTDOWN, 0, 0); This will result in a IMSG_NEIGHBOR_DOWN to lde

From RFC 5036 section 3.9. Status Code Summary I could not find an error that indicated to restart.

I think S_SHUTDOWN is the right status code for that.

rwestphal · 2020-04-24T01:18:19Z

ldpd/ldpe.c

@@ -980,3 +994,10 @@ mapping_list_clr(struct mapping_head *mh)
 		free(me);
 	}
 }
+
+void
+ldpe_check_filter_af(int af, struct ldpd_af_conf *af_conf, char *filter_name)


nit: const char *filter_name

rwestphal · 2020-04-24T01:20:20Z

ldpd/lde.c

+			plen = fn->fec.u.ipv6.prefixlen;
+			break;
+		default:
+			fatalx("lde_change_egress_label: unknown af");


nit: wrong function name (it's unfortunate fatalx doesn't accept format strings so that we could use __func__ here). Other calls to fatalx() need to be updated as well.

rwestphal · 2020-04-24T01:24:18Z

ldpd/lde.c

+		fatalx("lde_change_accept_to_filter: unknown af");
+	}
+	RB_FOREACH(ln, nbr_tree, &lde_nbrs) {
+		if (lde_acl_check(acl_name, af, (union ldpd_addr *)&ln->id, plen)


This should be 32 (or IPV4_MAX_BITLEN) instead of plen since ln->id is a router-id.

i stayed with 32 as it is used in other places in file. I couldn't find IPV4_MAX_BITLEN used in ldpd

Please use a #define and the appropriate define in this case is IPV4_MAX_BITLEN as Renato stated.

changed to use define

rwestphal · 2020-04-24T01:26:09Z

ldpd/lde.c

+				/* This fec is now allowed in filter, so send
+				 * labels
+				 */
+				if (fn->local_label != NO_LABEL)


nit: I think it would be better to have else if in a single line here.

rwestphal · 2020-04-24T01:34:14Z

ldpd/lde.c

+				!= FILTER_PERMIT) {
+				/* This fec is now filtered so send withdraw */
+				lde_send_labelwithdraw(ln, fn, NULL, NULL);
+				lde_map_del(ln, me, 1);


lde_map_del() should be called once we receive a label release for the label withdraw sent one line above. This shouldn't be necessary here.

Changes to ACL rules were not applied to LDP. This fix allows LDP to be notified when a rule in an ACL filter is modified by the user. The filter is properly applied to the LDP session. The filter may cause a LDP session to go down/up or to remove/add labels being advertised/received from a neighbor. Signed-off-by: Lynne Morrison <lynne@voltanet.io> Signed-off-by: Karen Schoener <karen@voltanet.io>

LabN-CI · 2020-04-29T17:32:24Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6241 `2d1aa1e`
Date	04/29/2020
Start	13:06:24
Finish	13:32:17
Run-Time	25:53
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-29-13:06:24.txt
Log	autoscript-2020-04-29-13:07:21.log.bz2
Memory	499 489 425

For details, please contact louberger

NetDEF-CI · 2020-04-29T18:03:35Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12086/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12086/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-00-g2d1aa1e88-0 (missing) -> 7.4-dev-20200429-00-g2d1aa1e88-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-00-g2d1aa1e88-0 (missing) -> 7.4-dev-20200429-00-g2d1aa1e88-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-00-g2d1aa1e88-0 (missing) -> 7.4-dev-20200429-00-g2d1aa1e88-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-00-g2d1aa1e88-0 (missing) -> 7.4-dev-20200429-00-g2d1aa1e88-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-00-g2d1aa1e88-0 (missing) -> 7.4-dev-20200429-00-g2d1aa1e88-0~deb10u1

rwestphal

@lynne-volta thanks for the updates. Looks excellent to me now. Merging...

polychaeta added the ldp label Apr 16, 2020

qlyoung reviewed Apr 16, 2020

View reviewed changes

mjstapp requested a review from rwestphal April 20, 2020 13:33

riw777 reviewed Apr 21, 2020

View reviewed changes

rwestphal requested changes Apr 24, 2020

View reviewed changes

lynne-volta requested a review from rwestphal April 29, 2020 18:27

rwestphal approved these changes Apr 30, 2020

View reviewed changes

rwestphal merged commit 31b5355 into FRRouting:master Apr 30, 2020

ldpd: fix ACL rule modification #6241

ldpd: fix ACL rule modification #6241

Conversation

lynne-volta commented Apr 16, 2020

NetDEF-CI commented Apr 16, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Apr 16, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Apr 16, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 16, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

2 Static Analyzer issues remaining.

LabN-CI commented Apr 16, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Apr 16, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 16, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NetDEF-CI commented Apr 16, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Apr 16, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Apr 17, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 17, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwestphal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lynne-volta Apr 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LabN-CI commented Apr 29, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 29, 2020

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Apr 16, 2020 •

edited

Loading

NetDEF-CI commented Apr 16, 2020 •

edited

Loading

LabN-CI commented Apr 16, 2020 •

edited

Loading

NetDEF-CI commented Apr 16, 2020 •

edited

Loading

LabN-CI commented Apr 16, 2020 •

edited

Loading

LabN-CI commented Apr 16, 2020 •

edited

Loading

NetDEF-CI commented Apr 16, 2020 •

edited

Loading

NetDEF-CI commented Apr 16, 2020 •

edited

Loading

LabN-CI commented Apr 16, 2020 •

edited

Loading

LabN-CI commented Apr 17, 2020 •

edited

Loading

NetDEF-CI commented Apr 17, 2020 •

edited

Loading

lynne-volta Apr 24, 2020 •

edited

Loading