Helm3 e2e. Helm-docs. Api v2 support. Add clamav chart. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudermanjr
requested review from
bambash,
dosullivan and
mgoodhart5
as code owners
|
I have an open issue with chart-test to figure out why we can't run |
sudermanjr
force-pushed
the
sudermanjr/clamav
branch
2 times, most recently
from
e9ba77d
to
05204c2
Compare
sudermanjr
changed the title
This ended up being my mistake but was just badly reported by chart-testing. Hopefully fixed in later releases. |
Adding helm-docs Adding note about helm-docs to the CONTRIBUTING Added CI to check that helm-docs is up-to-date Goldilocks helm-docs Update e2e testing to support helm3 and charts api v2
sudermanjr
force-pushed
the
sudermanjr/clamav
branch
from
6ebf6e7
to
cf646a7
Compare
bambash
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Looks great, thanks for cleaning things up and adding support for Helm 3! I tried installing the clamav chart, but the server is crashlooping:
LibClamAV Error: cli_loaddbdir(): No supported database files found in /data
I'm not familiar with clamav, but the chart looks great
That's odd. The e2e should cover that, and my other testing did as well. I'll take a look before I merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding helm-docs
Adding note about helm-docs to the CONTRIBUTING
Goldilocks helm-docs
e2e tests are only Helm3 now.
chart linting supports api v2
chart install timeout increased
add --upgrade flag to ct install