Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mujoco-py to mujoco and gym to gymnasium + more #421

Merged
merged 70 commits into from
Jul 12, 2023

Conversation

reginald-mclean
Copy link
Collaborator

@reginald-mclean reginald-mclean commented Jul 3, 2023

This PR updates multiple things:

  • Mujoco-Py to new MuJoco bindings
  • gym to gymnasium
  • migrated to gymnasium mujoco env from custom mujoco env
  • adding EzPickle
  • API updates were REMOVED due to errors during tests/jankiness that had to be introduced to get tests to pass
  • update setup to .toml file
  • drop support for Python <= 3.7
  • General bug fixes

Reggie-2 and others added 30 commits February 8, 2023 10:19
…ta-World consistency in README & CONTRIBUTING
Migrate the door envs to the new MuJoCo bindings & a couple minor changes
Migrate handle- envs to new MuJoCo bindings + fix misc issues (hand pos / rng)
Merging updated fixing issues from Farama-Foundation branch
@pseudo-rnd-thoughts
Copy link
Member

The CI is crashing currently due to too much process - Process completed with exit code 137.
This is highly alarming to me but would explain why there is a memory process test

My guess is that all of the environments are initialised using memory even when not used however we do something similar in gymnasium with no issue (on a smaller scale admittedly)

@pseudo-rnd-thoughts
Copy link
Member

Could you summarise the changes in the PR description
Update the PR location to master
Pre-commit should just require running pre-commit run --all-files

@reginald-mclean reginald-mclean changed the base branch from updating to master July 10, 2023 04:05
@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Updating to most recent updates Update mujoco-py to mujoco and gym to gymnasium + more Jul 10, 2023
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the number of interlinked changes, we have decided not to split this into several smaller pr (going forward this is the plan however).
Our plan is to continue improving the implement with this PR not being the final changes

README.md Outdated
@@ -20,23 +20,25 @@ __Table of Contents__
- [Acknowledgements](#acknowledgements)

## Join the Community
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

env_cls = classes[env_name]
env = env_cls()
for (env_name, args) in args_kwargs.items():
print(env_name, args)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -24,6 +24,6 @@
<position ctrllimited="true" ctrlrange="-1 1" joint="l_close" kp="400" user="1"/>
</actuator>
<equality>
<weld body1="mocap" body2="hand" solref="0.02 1"/>
<weld body1="mocap" body2="hand" solref="0.02 1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 19411bd into Farama-Foundation:master Jul 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants