Changing step to return truncate=True #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,11 +458,9 @@ def sawyer_observation_space(self): | |||
| def step(self, action): | |||
| assert len(action) == 4, f"Actions should be size 4, got {len(action)}" | |||
| self.set_xyz_action(action[:3]) | |||
| if self.curr_path_length == self.max_path_length: | |||
There was a problem hiding this comment.
Should this be greater than or equal?
There was a problem hiding this comment.
@pseudo-rnd-thoughts yeah that's fair. My thinking was that it should be impossible to ever get past the max path length but I can make that change
pseudo-rnd-thoughts
approved these changes
Oct 11, 2023
pseudo-rnd-thoughts
merged commit 185775b
into
Farama-Foundation:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the previous version of Meta-World, there was a check to see if the current trajectory has equalled the maximum trajectory length. Now with environments returning termination and truncation signals, we can add a check to see if truncate should be sent by comparing the current trajectory length to the maximum trajectory length. To ensure that the environment does get reset, the ValueError that was normally raised hasn't been changed.