Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncation Update #767

Merged
merged 75 commits into from
Sep 18, 2022
Merged

Truncation Update #767

merged 75 commits into from
Sep 18, 2022

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Aug 17, 2022 •
edited
Loading

About

This aims to do part 1 of #769.

done -> termination and truncation
- The singular done signal has been changed to a termination and truncation signal, where termination dictates that the environment has ended due to meeting certain conditions, and truncation dictates that the environment has ended due to exceeding the time/frame limit

Progress

The road plan for this update is as follows:

  1. Truncation/Termination update
    • MPE
    • MAgent
    • Butterfly
    • Atari
    • SISL
    • Classic
  2. Tests update
    • all_parameter_combs_test.py
      • MPE
      • MAgent
      • Butterfly
      • Atari
      • SISL
      • Classic
    • doc_example_test.py
    • print_test.py
    • pytest_runner_test.py
    • specific_env_test.py
    • unwrapped_test.py
    • variable_env_test.py

jjshoots and others added 22 commits August 12, 2022 14:10
@jjshoots
truncation update for atari env
45a58a4
@WillDudley
convert dones to terminations&truncations
940772a
@WillDudley
modifications so that mpe passes tests
198144e
@WillDudley
!2 Bugs ignored! modifications so that mpe passes ALL tests
5c3be1d
@WillDudley
pre-commit
b25427c
@jjshoots
Merge pull request #758 from jjshoots/master
ffe58c3 
Truncation Update for Atari Envs
@WillDudley
docstrings
d2b05ac
@jjshoots
rename dones -> terminations
6fd245e
@jjshoots
add truncation to magent env
7685996
@WillDudley
fixed merging of termination and truncation as dict items objects
05a406b
@WillDudley
fixed merging of termination and truncation as lists
85910e0
@WillDudley
fixed merging of termination and truncation
1ab4065
@WillDudley
docstring fix
2edb96e
@WillDudley
Merge remote-tracking branch 'fork/API_Update_mpe' into API_Update_mpe
a69a5f1
@FilipinoGambino
Truncation Update for butterfly envs
74c1658
@FilipinoGambino
Reverting chained inequalities back since they don't work like I'd ho…
64d389a 
…ped.
@FilipinoGambino
Reverting inequalities back
796f9b0
@WillDudley
uncomment a previously-broken assertion
f0c4e4d
@WillDudley
simplification/refactor
bfc081c
@WillDudley
uncomment assertion which now works as expected
b4e6bb9
@WillDudley
docstring
c72fbdb
@jjshoots
Merge pull request #761 from WillDudley/API_Update_mpe
fb41887 
[in progress] Truncation update for mpe
@jjshoots jjshoots marked this pull request as draft August 17, 2022 21:10
@jjshoots jjshoots mentioned this pull request Aug 19, 2022
Merged
@jjshoots jjshoots marked this pull request as ready for review September 1, 2022 09:28
@WillDudley
Copy link
Contributor

@jjshoots Any idea why prospector fails? Works on mine locally

@WillDudley
Copy link
Contributor

lgtm if prospector goes

@jjshoots
Copy link
Member Author

I'll need to get back and fix the conflicts, will merge once that's done. Thanks for the review!

WillDudley and others added 6 commits September 18, 2022 10:06
@WillDudley
Truncation update (#791)
2644d06
@jjshoots @jkterry1
@pseudo-rnd-thoughts @kir0ul @mgoulao
Api update conflicts (#792)
b8cb6c3 
Co-authored-by: Jordan Terry <jkterry0@gmail.com>
Co-authored-by: Mark Towers <mark.m.towers@gmail.com>
Co-authored-by: Andrea PIERRÉ <andrea_pierre@brown.edu>
Co-authored-by: Manuel Goulão <msilvagoulao@gmail.com>
@jjshoots @jkterry1
@pseudo-rnd-thoughts @kir0ul @mgoulao
Api update conflicts (#793)
a68e055 
Co-authored-by: Jordan Terry <jkterry0@gmail.com>
Co-authored-by: Mark Towers <mark.m.towers@gmail.com>
Co-authored-by: Andrea PIERRÉ <andrea_pierre@brown.edu>
Co-authored-by: Manuel Goulão <msilvagoulao@gmail.com>
@jjshoots
Merge branch 'master' into API_Update
936880b
@jjshoots
attempt to fix pydocstyle (#794)
136a6ee
@jjshoots
black (#795)
5848b4e
@WillDudley
Copy link
Contributor

lgtm

@jjshoots jjshoots merged commit 6cf14be into master Sep 18, 2022
@jjshoots jjshoots deleted the API_Update branch September 18, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjshoots @WillDudley @FilipinoGambino @reginald-mclean