-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Docker image for reprepro
#309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the issue description:
See existing directories with Dockerfile and Makefile for examples.
There is no Makefile at all, and the entrypoint is very different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lack full context to give complete review.
ferretdb-repo/Dockerfile
Outdated
@@ -0,0 +1,16 @@ | |||
FROM debian:experimental-20240722 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, do we want to build on top op experimental image? I might not understand the full requirement of reporepro
though, a comment here would be very useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some functionality (support for multiple signatures, I think?) that is not available in the stable Debian release yet
ferretdb-repo/apt/distributions
Outdated
Architectures: armhf arm64 amd64 | ||
Components: main | ||
Description: Apt repository for FerretDB | ||
Limit: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Limit? I'm not seeing it in debian repository format https://wiki.debian.org/DebianRepository/Format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be there
ferretdb-repo/Dockerfile
Outdated
|
||
ENV REPREPRO_BASE_DIR=/srv/repos/apt/debian | ||
|
||
RUN mkdir -p /var/inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this directory use for? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be there
ferretdb-repo/Dockerfile
Outdated
@@ -0,0 +1,16 @@ | |||
FROM debian:experimental-20240722 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be in a new directory at https://github.com/FerretDB/deps.
The description of this issue says this. Has this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in the directory now
ferretdb-repo/Dockerfile
Outdated
|
||
EXPOSE 22 | ||
ENTRYPOINT ["/bin/reprepro"] | ||
CMD ["-h"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "-h"
do 🤔 it seems to me an invalid commad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bin/reprepro -h
shows help
ferretdb-repo/Dockerfile
Outdated
apt-get install -yq ssh && \ | ||
apt-get -t experimental install -yq reprepro | ||
|
||
EXPOSE 22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we use ssh for docker to host? a comment would be useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For passing GPG socket through SSH
ferretdb-reprepro/Makefile
Outdated
--load . | ||
|
||
build-push: | ||
rm -fr node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to use npm anywhere here?
Closes FerretDB/Engineering#186.