Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Docker image for reprepro #309

Merged
merged 23 commits into from
Aug 26, 2024
Merged

Conversation

noisersup
Copy link
Member

Closes FerretDB/Engineering#186.

@noisersup noisersup self-assigned this Aug 12, 2024
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the issue description:

See existing directories with Dockerfile and Makefile for examples.

There is no Makefile at all, and the entrypoint is very different.

ferretdb-repo/reprepro/docker-entrypoint.sh Outdated Show resolved Hide resolved
@noisersup noisersup marked this pull request as ready for review August 16, 2024 13:18
@noisersup noisersup enabled auto-merge (squash) August 16, 2024 13:18
@noisersup noisersup requested review from a team, rumyantseva, chilagrow and AlekSi August 16, 2024 13:18
Copy link

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack full context to give complete review.

@@ -0,0 +1,16 @@
FROM debian:experimental-20240722

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, do we want to build on top op experimental image? I might not understand the full requirement of reporepro though, a comment here would be very useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some functionality (support for multiple signatures, I think?) that is not available in the stable Debian release yet

Architectures: armhf arm64 amd64
Components: main
Description: Apt repository for FerretDB
Limit: 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Limit? I'm not seeing it in debian repository format https://wiki.debian.org/DebianRepository/Format

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be there


ENV REPREPRO_BASE_DIR=/srv/repos/apt/debian

RUN mkdir -p /var/inputs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this directory use for? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be there

@@ -0,0 +1,16 @@
FROM debian:experimental-20240722

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in a new directory at https://github.com/FerretDB/deps.

The description of this issue says this. Has this changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the directory now


EXPOSE 22
ENTRYPOINT ["/bin/reprepro"]
CMD ["-h"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "-h" do 🤔 it seems to me an invalid commad.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bin/reprepro -h shows help

apt-get install -yq ssh && \
apt-get -t experimental install -yq reprepro

EXPOSE 22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we use ssh for docker to host? a comment would be useful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For passing GPG socket through SSH

--load .

build-push:
rm -fr node_modules
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to use npm anywhere here?

@AlekSi AlekSi disabled auto-merge August 26, 2024 09:21
@AlekSi AlekSi merged commit cc2bbfb into FerretDB:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants