Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for #[dynamic_link] and #[callable_point] #188

Merged
merged 3 commits into from
May 10, 2022
Merged

test: add unit tests for #[dynamic_link] and #[callable_point] #188

merged 3 commits into from
May 10, 2022

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented May 3, 2022 •
edited
Loading

Description

Closes #186

  • add unit tests for #[dynamic_link] and #[callable_point]
    Due to the limitations of proc macro test implementation,
    test logic cannot be added where attribute and proc-macro-error are used.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

test: add unit tests for #[dynamic_link] and #[callable_point]
98a46a7 
Due to the limitations of proc macro test implementation,
test logic cannot be added where attribute and proc-macro-error are used.
@brew0722 brew0722 added the dynamic_link relate the dynamic link call feature label May 3, 2022
@brew0722 brew0722 self-assigned this May 3, 2022
loloicci
loloicci reviewed May 6, 2022
View reviewed changes
packages/derive/src/callable_point.rs Outdated Show resolved Hide resolved
packages/derive/src/dynamic_link.rs Outdated Show resolved Hide resolved
packages/derive/src/callable_point.rs Outdated Show resolved Hide resolved
@brew0722 brew0722 requested a review from loloicci May 9, 2022 08:18
shiki-tak
shiki-tak approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit d81a930 into Finschia:dynamic_link May 10, 2022
@brew0722 brew0722 deleted the unit_test_for_macro branch May 10, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@loloicci loloicci loloicci approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@brew0722 brew0722

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brew0722 @shiki-tak @loloicci