Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Add benchmarks for estimate dynamic link gas cost #224

Merged
merged 5 commits into from
Aug 18, 2022
Merged

perf: Add benchmarks for estimate dynamic link gas cost #224

merged 5 commits into from
Aug 18, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Aug 8, 2022 •
edited
Loading

Description

Add some benchmarks to estimate dynamic link gas cost.

  • benchmarking native_dynamic_link_trampoline: used to estimate the gas cost to call for a dynamic linked function. calling a dynamic linked function takes this time and time to execute contract_call.
  • benchmarking read/write_region: used to estimate the gas cost for copy values between two contract instances. This copy is executed in contract_call.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Aug 8, 2022
@loloicci loloicci self-assigned this Aug 8, 2022
@loloicci loloicci requested a review from da1suk8 August 9, 2022 08:49
shiki-tak
shiki-tak approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit a227bee into Finschia:dynamic_link Aug 18, 2022
@loloicci loloicci deleted the benchmarking branch August 18, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@da1suk8 da1suk8 da1suk8 approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @shiki-tak @da1suk8