Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit max regions' length used by calling dynamic link function #240

Merged
merged 1 commit into from
Sep 5, 2022
Merged

feat: limit max regions' length used by calling dynamic link function #240

merged 1 commit into from
Sep 5, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Sep 2, 2022

Description

This PR limits the max length of used by arg/return value's region with the dynamic link.

closes #190

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Sep 2, 2022
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Sep 2, 2022
@loloicci loloicci marked this pull request as ready for review September 2, 2022 12:01
shiki-tak
shiki-tak approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 424de0f into Finschia:dynamic_link Sep 5, 2022
@loloicci loloicci deleted the limit-region branch September 5, 2022 07:00
@loloicci loloicci mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@da1suk8 da1suk8 da1suk8 approved these changes

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @shiki-tak @da1suk8