Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: error handling after check tx" #180

Conversation

wetcod
Copy link
Contributor

@wetcod wetcod commented Feb 4, 2021

Related https://github.com/line/link/issues/1176

Description

We decide to apply #158 instead of #178.
So revert #178.

For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@wetcod wetcod self-assigned this Feb 4, 2021
@wetcod wetcod changed the base branch from revert-178-fix-error-handling-after-check-tx to v0.33.x-0.1.x February 4, 2021 09:27
@wetcod wetcod changed the title Revert "fix: error handling after check tx (#178)" Revert "fix: error handling after check tx" Feb 4, 2021
@wetcod wetcod merged commit 629ddc8 into Finschia:v0.33.x-0.1.x Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants