Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arm64 and arm #315

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Support arm64 and arm #315

merged 3 commits into from
Sep 8, 2021

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Sep 8, 2021 •
edited
Loading

Description

  • Just enabled to support arm64and arm
  • Refactored job names on github actions

@tnasu tnasu requested review from torao and Kynea0b September 8, 2021 03:15
@tnasu tnasu self-assigned this Sep 8, 2021
@tnasu tnasu changed the title Support arm64 Support arm64 and arm Sep 8, 2021
torao
torao approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kynea0b
Kynea0b approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torao
Copy link
Contributor

torao commented Sep 8, 2021 •
edited
Loading

Where are these arm64 builds tested in CircleCI?

@tnasu
Copy link
Member Author

tnasu commented Sep 8, 2021 •
edited
Loading

I always use act for github actions test in local.

Example commands:

// hook=pull_request, job=build-linux
act pull_request -j build-linux -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest

// hook=push, job=build-docker
act push -j build-docker -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest

JFY:
ubuntu-latest usually use Micro Docker Image = node:12-buster-slim in local

So I specify P and use Medium Docker Image = ghcr.io/catthehacker/ubuntu:act-latest

  -P, --platform stringArray             custom image to use per platform (e.g. -P ubuntu-18.04=nektos/act-environments-ubuntu:18.04)

@tnasu tnasu merged commit dbe53cb into Finschia:main Sep 8, 2021
@tnasu tnasu deleted the main-support-arm64 branch September 9, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b