Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify omission of change to change ValidatorSet to VoterSet #340

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Modify omission of change to change ValidatorSet to VoterSet #340

merged 1 commit into from
Nov 4, 2021

Conversation

Kynea0b
Copy link
Contributor

@Kynea0b Kynea0b commented Nov 4, 2021

Description

  • Corresponding to the omission of change from the validator set to the voter set during version upgrade work.
    This commit change was not reflected.
    25fe25c

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021

CLA assistant check
All committers have signed the CLA.

@Kynea0b Kynea0b self-assigned this Nov 4, 2021
@Kynea0b Kynea0b changed the title fix: Fix omission of change to change ValidatorSet to VoterSet fix: Modify omission of change to change ValidatorSet to VoterSet Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #340 (a58a3cf) into main (c4d40bc) will increase coverage by 0.17%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   62.82%   62.99%   +0.17%     
==========================================
  Files         272      272              
  Lines       30214    30259      +45     
==========================================
+ Hits        18982    19063      +81     
+ Misses       9504     9465      -39     
- Partials     1728     1731       +3     
Impacted Files Coverage Δ
crypto/bls/bls.go 48.41% <0.00%> (ø)
crypto/sr25519/privkey.go 49.05% <ø> (ø)
crypto/vrf/vrf_r2ishiguro.go 100.00% <ø> (ø)
libs/log/testing_logger.go 0.00% <ø> (ø)
types/block.go 75.56% <50.00%> (-0.17%) ⬇️
crypto/encoding/codec.go 61.53% <66.66%> (+1.01%) ⬆️
abci/example/kvstore/persistent_kvstore.go 49.41% <73.68%> (+7.28%) ⬆️
crypto/composite/composite.go 86.66% <81.81%> (+0.95%) ⬆️
abci/example/kvstore/helpers.go 100.00% <100.00%> (ø)
consensus/state.go 70.43% <100.00%> (-0.25%) ⬇️
... and 20 more

@Kynea0b Kynea0b requested review from torao and tnasu November 4, 2021 07:54
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b Kynea0b added the C: bug Classification: Something isn't working label Nov 4, 2021
@Kynea0b Kynea0b added the P: emergency Priority: Emergency issue label Nov 4, 2021
@Kynea0b Kynea0b changed the title fix: Modify omission of change to change ValidatorSet to VoterSet Modify omission of change to change ValidatorSet to VoterSet Nov 4, 2021
@Kynea0b Kynea0b merged commit b628591 into Finschia:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working P: emergency Priority: Emergency issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants