Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version.go (Rollback to only use OCCoreSemVer) #348

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Nov 26, 2021

Description

version.go does not work correctry. I fix to only use OCCoreSemVer.

Appendix

How to set version.go:OCCoreSemVer

BUILD_FLAGS = -ldflags "-X github.com/line/ostracon/version.OCCoreSemVer=$(VERSION)"

How to get VERSION from git the version

VERSION := $(shell git describe --always)

@tnasu tnasu force-pushed the main-fix-version branch 3 times, most recently from 9e5424b to 3e79e20 Compare November 29, 2021 07:16
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #348 (16b943b) into main (5f56d8c) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   63.02%   62.93%   -0.09%     
==========================================
  Files         272      272              
  Lines       30253    30253              
==========================================
- Hits        19068    19041      -27     
- Misses       9459     9480      +21     
- Partials     1726     1732       +6     
Impacted Files Coverage Δ
cmd/ostracon/commands/version.go 100.00% <100.00%> (+100.00%) ⬆️
privval/socket_listeners.go 82.75% <0.00%> (-3.45%) ⬇️
blockchain/v1/reactor.go 69.62% <0.00%> (-3.08%) ⬇️
privval/signer_listener_endpoint.go 87.87% <0.00%> (-2.03%) ⬇️
statesync/syncer.go 78.62% <0.00%> (-1.53%) ⬇️
libs/clist/clist.go 66.66% <0.00%> (-1.52%) ⬇️
blockchain/v0/pool.go 78.48% <0.00%> (-1.27%) ⬇️
abci/client/socket_client.go 75.85% <0.00%> (-1.03%) ⬇️
blockchain/v0/reactor.go 68.01% <0.00%> (-0.91%) ⬇️
p2p/switch.go 67.09% <0.00%> (-0.52%) ⬇️
... and 7 more

@tnasu tnasu marked this pull request as ready for review November 29, 2021 08:51
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 29, 2021
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit ebcfa43 into Finschia:main Nov 30, 2021
@tnasu tnasu deleted the main-fix-version branch November 30, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants