Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main patch from tm-v0.34.10 #358

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Main patch from tm-v0.34.10 #358

merged 5 commits into from
Jan 6, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Jan 6, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #358 (830163f) into main (ebcfa43) will increase coverage by 1.14%.
The diff coverage is 66.48%.

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   62.96%   64.11%   +1.14%     
==========================================
  Files         272      274       +2     
  Lines       30253    30692     +439     
==========================================
+ Hits        19048    19677     +629     
+ Misses       9475     9244     -231     
- Partials     1730     1771      +41
Impacted Files Coverage Δ
abci/types/application.go 0.00% <ø> (ø)
cmd/ostracon/commands/light.go 17.24% <0.00%> (+1.41%) ⬆️
crypto/merkle/proof_value.go 0.00% <0.00%> (ø)
light/errors.go 75.00% <ø> (-2.78%) ⬇️
p2p/conn/secret_connection.go 83.49% <ø> (ø)
rpc/core/env.go 68.08% <0.00%> (+10.63%) ⬆️
rpc/core/routes.go 0.00% <ø> (ø)
rpc/core/types/responses.go 36.36% <ø> (ø)
state/txindex/indexer.go 75.00% <ø> (ø)
types/events.go 100.00% <ø> (ø)
... and 62 more

tnasu and others added 2 commits January 6, 2022 11:50
@tnasu
e2e: tx load to use broadcast sync instead of commit (backport #6347)…
6635919 
… (#6352)
@tnasu @cmwaters
e2e: relax timeouts (#6356)
830163f 
* remove duplicate light error

* quieten handling of txs that already exist in the mempool

* notch back e2e timeouts

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@tnasu tnasu marked this pull request as ready for review January 6, 2022 03:44
torao
torao approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jan 6, 2022
@tnasu tnasu merged commit fb1b65d into Finschia:main Jan 6, 2022
@tnasu tnasu deleted the main-patch-tm-v0.34.10 branch January 6, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b