Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main patch tm v0.34.14 #366

Merged
merged 9 commits into from
Feb 16, 2022
Merged

Main patch tm v0.34.14 #366

merged 9 commits into from
Feb 16, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Jan 28, 2022

@tnasu tnasu force-pushed the main-patch-tm-v0.34.14 branch 2 times, most recently from b709d12 to fc97913 Compare January 31, 2022 07:31
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #366 (861f90a) into main (7320ceb) will increase coverage by 0.71%.
The diff coverage is 69.64%.

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   64.47%   65.19%   +0.71%     
==========================================
  Files         274      278       +4     
  Lines       30698    30668      -30     
==========================================
+ Hits        19792    19993     +201     
+ Misses       9133     8897     -236     
- Partials     1773     1778       +5     
Impacted Files Coverage Δ
cmd/ostracon/commands/rollback.go 0.00% <0.00%> (ø)
cmd/ostracon/commands/run_node.go 0.00% <0.00%> (ø)
config/config.go 80.75% <ø> (ø)
config/toml.go 68.00% <ø> (ø)
evidence/pool.go 70.28% <0.00%> (ø)
proxy/client.go 22.22% <0.00%> (-3.59%) ⬇️
rpc/core/abci.go 0.00% <ø> (ø)
rpc/core/consensus.go 0.00% <0.00%> (ø)
rpc/core/routes.go 0.00% <ø> (ø)
rpc/core/types/responses.go 36.36% <ø> (ø)
... and 38 more

tnasu and others added 9 commits February 10, 2022 15:51
Co-authored-by: Sam Kleinman <garen@tychoish.com>
Co-authored-by:    Callum Waters <cmwaters19@gmail.com>
I accidentally omitted this from the backport in #6906.
Fixes #7043.

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
…78) (#7085)

* e2e: abci protocol should be consistent across networks (#7078)

It seems weird in retrospect that we allow networks to contain
applications that use different ABCI protocols.

(cherry picked from commit f2a8f5e054cf99ebe246818bb6d71f41f9a30faa)
(cherry picked from commit befd669794af282733ecccabb50d3f18de154c61)

Co-authored-by: Sam Kleinman <garen@tychoish.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@tnasu tnasu marked this pull request as ready for review February 10, 2022 07:24
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Feb 10, 2022
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit a0c3c4a into Finschia:main Feb 16, 2022
@tnasu tnasu deleted the main-patch-tm-v0.34.14 branch February 28, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants