Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker Buildx and Cache in e2e.yml #408

Merged
merged 5 commits into from
May 24, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Apr 28, 2022

Description

Current

18m 8s

Build CI Test
13m 55s 3m 46s

Use cache on Docker Image Layer

Reduce the build time:
11m 40s

Build CI Test Get Docker Image Layer Cache
5m 53s 4m 4s 26s

Use cache on Docker Image File

Cut the build time, but increase the saving time of Docker Image:
7m 9s

Build Save Store
5m 58s 2m 1s 51s
CI Test Get Docker Image Cache File Load Docker Image File
3m 18s 48s 1m 56s

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #408 (d90eebe) into main (67bc61f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d90eebe differs from pull request most recent head 41f8dc2. Consider uploading reports for the commit 41f8dc2 to get more accurate results

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   65.37%   65.38%   +0.01%     
==========================================
  Files         277      277              
  Lines       37842    37842              
==========================================
+ Hits        24738    24742       +4     
- Misses      11290    11291       +1     
+ Partials     1814     1809       -5     
Impacted Files Coverage Δ
consensus/reactor.go 75.28% <0.00%> (-2.49%) ⬇️
types/voter_set.go 84.17% <0.00%> (-0.85%) ⬇️
consensus/state.go 74.02% <0.00%> (+0.58%) ⬆️
blockchain/v0/reactor.go 70.16% <0.00%> (+0.67%) ⬆️
proxy/multi_app_conn.go 51.40% <0.00%> (+3.73%) ⬆️
blockchain/v0/pool.go 82.42% <0.00%> (+4.39%) ⬆️
crypto/sr25519/pubkey.go 43.58% <0.00%> (+7.69%) ⬆️

@github-actions
Copy link

github-actions bot commented May 9, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale For github bot label May 9, 2022
@tnasu tnasu self-assigned this May 11, 2022
@tnasu tnasu force-pushed the main-improve-e2e-test branch 8 times, most recently from e0fb3f3 to 5ad8ee7 Compare May 18, 2022 10:44
@tnasu tnasu force-pushed the main-improve-e2e-test branch 2 times, most recently from 4866f52 to 22f2375 Compare May 19, 2022 09:22
@tnasu tnasu force-pushed the main-improve-e2e-test branch 2 times, most recently from 6bdf2cb to d90eebe Compare May 20, 2022 09:16
@tnasu tnasu marked this pull request as ready for review May 23, 2022 01:55
@tnasu tnasu requested review from Kynea0b and torao as code owners May 23, 2022 01:55
@torao torao added C: enhancement Classification: New feature or its request, or improvement in maintainability of code and removed Stale For github bot labels May 23, 2022
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit 85eb4f6 into Finschia:main May 24, 2022
@tnasu tnasu deleted the main-improve-e2e-test branch June 20, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants