Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/adlio/schema from 1.3.0 to 1.3.3 #435

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 20, 2022

Bumps github.com/adlio/schema from 1.3.0 to 1.3.3.

Release notes

Sourced from github.com/adlio/schema's releases.

v1.3.3

Full Changelog: adlio/schema@v1.3.1...v1.3.3

v1.3.1

What's Changed

Full Changelog: adlio/schema@v1.3.0...v1.3.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/adlio/schema](https://github.com/adlio/schema) from 1.3.0 to 1.3.3.
- [Release notes](https://github.com/adlio/schema/releases)
- [Commits](adlio/schema@v1.3.0...v1.3.3)

---
updated-dependencies:
- dependency-name: github.com/adlio/schema
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #435 (fbe5a3b) into main (6069aff) will increase coverage by 0.42%.
The diff coverage is 75.83%.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   65.15%   65.57%   +0.42%     
==========================================
  Files         278      278              
  Lines       37743    37954     +211     
==========================================
+ Hits        24590    24888     +298     
+ Misses      11370    11259     -111     
- Partials     1783     1807      +24     
Impacted Files Coverage Δ
mempool/errors.go 25.00% <ø> (ø)
privval/file.go 74.90% <0.00%> (-0.10%) ⬇️
cmd/ostracon/commands/reset.go 50.44% <50.44%> (ø)
mempool/clist_mempool.go 82.41% <68.75%> (-1.41%) ⬇️
crypto/secp256k1/secp256k1.go 69.56% <75.67%> (+2.89%) ⬆️
cmd/ostracon/commands/show_validator.go 72.72% <82.35%> (+72.72%) ⬆️
consensus/state.go 74.25% <93.18%> (+1.03%) ⬆️
abci/client/grpc_client.go 69.37% <100.00%> (-0.12%) ⬇️
config/toml.go 74.19% <100.00%> (+0.86%) ⬆️
consensus/reactor.go 75.64% <100.00%> (+2.89%) ⬆️
... and 19 more

@torao torao self-assigned this Jun 21, 2022
@torao
Copy link
Contributor

torao commented Jun 21, 2022

Thanks for PR, dependabot. Now ready to review @tnasu @kokeshiM0chi .

I believe this fix contains a runc version upgrade related to #429 and I'm planning to create a new one which is confirmed that only the runc version we intended is used after this PR is merged.

Specifically, this PR contains the following upgrade:

- github.com/ory/dockertest v3.3.5+incompatible
+ github.com/ory/dockertest/v3 v3.9.1

Also, an upgrade for runc 1.1.2 is contained in the ory/dockertest v3.9.1 release note:

Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.1 to 1.1.2.

Therefore, this PR will probably allow us to remove the following temporary fix added in #429.

replace github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.2

@Kynea0b
Copy link
Contributor

Kynea0b commented Jun 21, 2022

With this version, the runc version is up. Please remove the temporary correction #429.

Kynea0b
Kynea0b previously approved these changes Jun 21, 2022
@tnasu
Copy link
Member

tnasu commented Jun 21, 2022

Therefore, this PR will probably allow us to remove the following temporary fix added in #429.

Would you try it?

@torao
Copy link
Contributor

torao commented Jun 21, 2022

@tnasu I'm not doing it. Since even if I do it either before or after this PR is merged, there will be no change in what I should do.

@torao torao force-pushed the dependabot/go_modules/github.com/adlio/schema-1.3.3 branch from d045f97 to 601802f Compare June 21, 2022 10:07
@torao torao requested a review from Kynea0b June 21, 2022 11:25
@torao
Copy link
Contributor

torao commented Jun 21, 2022

Eventually, I've added a commit as I've confirmed that the only dependencies are runc v1.1.2 and v1.1.3.
Please review this @tnasu @kokeshiM0chi

Kynea0b
Kynea0b previously approved these changes Jun 21, 2022
tnasu
tnasu previously approved these changes Jun 22, 2022
Copy link
Member

@tnasu tnasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your response.

@torao torao dismissed stale reviews from tnasu and Kynea0b via fbe5a3b June 22, 2022 04:50
@torao torao requested review from tnasu and Kynea0b June 22, 2022 06:25
@torao torao merged commit 87768f8 into main Jun 22, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/adlio/schema-1.3.3 branch June 22, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants