Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error when AddChannel fails #500

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Nov 14, 2022

Description

AddChannel doesn't return an error if adding a channel fails. I fixed AddChannel to return an error on failure.

@ulbqb ulbqb self-assigned this Nov 14, 2022
@ulbqb ulbqb changed the title fix: add error handling in AddChannel function fix: return error when AddChannel fails Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #500 (dfcf497) into main (0681636) will increase coverage by 0.04%.
The diff coverage is 76.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   65.44%   65.49%   +0.04%     
==========================================
  Files         278      278              
  Lines       37936    37972      +36     
==========================================
+ Hits        24828    24868      +40     
+ Misses      11305    11294      -11     
- Partials     1803     1810       +7     
Impacted Files Coverage Δ
p2p/node_info.go 95.12% <ø> (ø)
p2p/transport.go 82.77% <66.66%> (-0.71%) ⬇️
node/node.go 60.20% <100.00%> (+0.08%) ⬆️
mempool/reactor.go 78.57% <0.00%> (-1.10%) ⬇️
consensus/reactor.go 74.22% <0.00%> (-0.98%) ⬇️
consensus/wal.go 60.88% <0.00%> (-0.89%) ⬇️
consensus/state.go 73.50% <0.00%> (-0.35%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
... and 6 more

@ulbqb ulbqb marked this pull request as ready for review November 15, 2022 03:35
Mdaiki0730
Mdaiki0730 previously approved these changes Nov 15, 2022
@tnasu tnasu added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 15, 2022
node/node.go Outdated Show resolved Hide resolved
p2p/transport_test.go Outdated Show resolved Hide resolved
@ulbqb ulbqb requested a review from tnasu November 16, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants