Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint to v1.50.1 #505

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Upgrade golangci-lint to v1.50.1 #505

merged 2 commits into from
Nov 24, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Nov 22, 2022

Description

We're using the old one of golangci-lint-v1.42.1 and the latest one of golangci-lint-action-v3.3.1. And depandabot can upgrade golangci-lint-action only, which means that we have to upgrade golangci-lint manually. I fixed it with the latest tendermint's lint.yml. Of course, the existing code was affected, so I also fixed that.

In addition, .golangci.yml is used for make lint only, so I removed it.

@tnasu tnasu self-assigned this Nov 22, 2022
@tnasu tnasu added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #505 (284f47c) into main (2828a22) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   65.39%   65.49%   +0.09%     
==========================================
  Files         278      278              
  Lines       37972    37995      +23     
==========================================
+ Hits        24833    24885      +52     
+ Misses      11324    11300      -24     
+ Partials     1815     1810       -5     
Impacted Files Coverage Δ
crypto/ed25519/ed25519.go 45.12% <0.00%> (-1.22%) ⬇️
abci/client/socket_client.go 72.09% <0.00%> (-0.88%) ⬇️
light/client.go 61.17% <0.00%> (-0.45%) ⬇️
blockchain/v0/pool.go 78.81% <0.00%> (-0.26%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
crypto/vrf/vrf_r2ishiguro.go
crypto/vrf/vrf_libsodium.go 78.57% <0.00%> (ø)
consensus/state.go 74.08% <0.00%> (+0.81%) ⬆️
consensus/msgs.go 85.10% <0.00%> (+0.91%) ⬆️
mempool/reactor.go 79.67% <0.00%> (+1.09%) ⬆️
... and 3 more

@tnasu tnasu marked this pull request as ready for review November 22, 2022 10:08
@Mdaiki0730 Mdaiki0730 self-requested a review November 22, 2022 10:09
@tnasu tnasu merged commit e6f57a1 into Finschia:main Nov 24, 2022
@tnasu tnasu deleted the main-lint branch November 25, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants