Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add block validation on Fast Sync #517

Merged
merged 2 commits into from
Dec 2, 2022
Merged

fix: add block validation on Fast Sync #517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e31f06a
Add `ValidateBlock`
ulbqb Dec 1, 2022
3570b83
Merge branch 'main' into fix/fast_sync
ulbqb Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions blockchain/v0/reactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,14 @@ FOR_LOOP:
// NOTE: we can probably make this more efficient, but note that calling
// first.Hash() doesn't verify the tx contents, so MakePartSet() is
// currently necessary.
err := state.Voters.VerifyCommitLight(
chainID, firstID, first.Height, second.LastCommit)
err := state.Voters.VerifyCommitLight(chainID, firstID, first.Height, second.LastCommit)
if err == nil {
// validate the block before we persist it
err = bcR.blockExec.ValidateBlock(state, first.Round, first)
}

// If either of the checks failed we log the error and request for a new block
// at that height
if err != nil {
bcR.Logger.Error("Error in validation", "err", err)
peerID := bcR.pool.RedoRequest(first.Height)
Expand Down