Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of Ostracon's changes of #194 #526

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Dec 12, 2022

Description

#194 was made of too many things. But, it made some of the wrong changes. Here are the wrong changes:

  • Remove to call CheckEvidence on execution.go:ValidateBlock
  • Forget to add the fields of Round/Proof on protobuf.go:Header
  • Mistake to remove the field of ValidatorHash on protobuf.go:Header
  • Forget to add the field of VotingWeight on validator.go:String

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #526 (aa125f5) into main (7ba5191) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   65.99%   66.17%   +0.17%     
==========================================
  Files         279      279              
  Lines       38028    38038      +10     
==========================================
+ Hits        25097    25172      +75     
+ Misses      11129    11073      -56     
+ Partials     1802     1793       -9     
Impacted Files Coverage Δ
state/execution.go 67.46% <100.00%> (+0.31%) ⬆️
types/protobuf.go 81.70% <100.00%> (+1.18%) ⬆️
types/validator.go 83.05% <100.00%> (+0.14%) ⬆️
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
statesync/snapshots.go 93.71% <0.00%> (-1.26%) ⬇️
p2p/pex/pex_reactor.go 79.67% <0.00%> (-0.62%) ⬇️
consensus/state.go 73.88% <0.00%> (+0.34%) ⬆️
p2p/conn/connection.go 80.38% <0.00%> (+0.57%) ⬆️
statesync/syncer.go 82.80% <0.00%> (+0.57%) ⬆️
p2p/switch.go 66.52% <0.00%> (+0.61%) ⬆️
... and 10 more

@tnasu tnasu marked this pull request as ready for review December 12, 2022 02:31
@torao torao added the C: bug Classification: Something isn't working label Dec 14, 2022
@Mdaiki0730 Mdaiki0730 self-requested a review December 14, 2022 07:24
@tnasu tnasu merged commit 2f25796 into Finschia:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants