fix: add support for dns timeout #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
added
the
C: enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 65.99% 65.99% -0.01%
==========================================
Files 279 279
Lines 38028 38035 +7
==========================================
+ Hits 25097 25101 +4
- Misses 11129 11132 +3
Partials 1802 1802
|
tnasu
previously approved these changes
Dec 12, 2022
torao
reviewed
Dec 12, 2022
torao
reviewed
Dec 13, 2022
tnasu
approved these changes
Dec 14, 2022
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When requesting information from an external system, like DNS, the caller should always consider a timeout period for the operation to finish. The current implementation lacks timeout control since it uses context.Background().