Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker building during e2e test #732

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Oct 5, 2023

Description

This PR stops caching docker image because this was for libsodium and change it to become the same as original jobs.
original: https://github.com/tendermint/tendermint/blob/v0.34.24/.github/workflows/e2e.yml

Closes: #XXX

@ulbqb ulbqb requested review from torao and tnasu as code owners October 5, 2023 02:55
@ulbqb ulbqb self-assigned this Oct 5, 2023
@ulbqb ulbqb added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #732 (2a26051) into main (c8b0705) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2a26051 differs from pull request most recent head 622d7c1. Consider uploading reports for the commit 622d7c1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   66.49%   66.55%   +0.05%     
==========================================
  Files         285      285              
  Lines       37919    37919              
==========================================
+ Hits        25216    25238      +22     
+ Misses      10892    10878      -14     
+ Partials     1811     1803       -8     

see 9 files with indirect coverage changes

This reverts commit a02c89e.
@ulbqb ulbqb merged commit b5680b2 into Finschia:main Oct 6, 2023
22 checks passed
@ulbqb ulbqb deleted the fix/e2e_ci_docker branch October 6, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants