Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add copies region of args and returns between env #56

Merged
merged 5 commits into from
Mar 31, 2022
Merged

feat: add copies region of args and returns between env #56

merged 5 commits into from
Mar 31, 2022

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented Feb 23, 2022 •
edited
Loading

Description

Closes Finschia/cosmwasm#157

  • Add copying serialized data on VM host side.

Please The dynamic_link poc PR(#55) first. This PR is based on #55.
#55 must be merged first before this PR can be reviewed.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@brew0722 brew0722 added enhancement New feature or request dynamic_link relate the dynamic link call feature labels Feb 23, 2022
@brew0722 brew0722 self-assigned this Feb 23, 2022
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@brew0722 brew0722 marked this pull request as ready for review March 10, 2022 04:06
@brew0722
Copy link
Contributor Author

brew0722 commented Mar 18, 2022 •
edited
Loading

force pushed because it based on PR #55 , and PR #55 is squash merged now.
So I rebased for that.

shiki-tak
shiki-tak approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit 721edcb into Finschia:dynamic_link Mar 31, 2022
@brew0722 brew0722 deleted the region_copy_pass branch March 31, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@loloicci loloicci loloicci approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@brew0722 brew0722

Labels
dynamic_link relate the dynamic link call feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brew0722 @CLAassistant @shiki-tak @loloicci