Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected tab from overflow stays in overflow #16

Closed
paodb opened this issue Jul 5, 2024 · 3 comments · Fixed by #19
Closed

Selected tab from overflow stays in overflow #16

paodb opened this issue Jul 5, 2024 · 3 comments · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@paodb
Copy link
Member

paodb commented Jul 5, 2024

Describe the bug

Go to https://addonsv24.flowingcode.com/ and select Google Maps add-on from the side bar. See that Track Location demo is shown in the overflow. Click on it to see that demo. The demo is not shown adn the tab remains in the overflow. When repeating this steps but with the side bar being closed, then the tab seems to fit in the screen and the demo is then shown.

Expected behavior

Tab should become visible when selected from overflow menu.

Minimal reproducible example

tabs-google-maps

Add-on Version

1.1.0

Vaadin Version

24.4.1

Additional information

Tested on latest Chrome, zoom 100%. Resolution 1920 x 1080.

@javier-godoy javier-godoy self-assigned this Jul 5, 2024
@javier-godoy
Copy link
Member

@paodb Can you please try to reproduce again in staging? (I'm not sure if this is another occurrence of #17, or whether the long tab "clustering with custom renderer" requires additional processing when moving it out of the overflow section)

@javier-godoy javier-godoy added the question Further information is requested label Jul 8, 2024
@paodb
Copy link
Member Author

paodb commented Jul 8, 2024

@javier-godoy Still happening tabs-google-maps-issue-16

@javier-godoy javier-godoy added bug Something isn't working and removed question Further information is requested labels Jul 8, 2024
@javier-godoy
Copy link
Member

Steps to reproduce

Go to https://addonsv24-staging.flowingcode.com/googlemaps/

image

Select "Customized Marker Icons"

image

Expected behavior

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants