Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setChartExpandCollapse doesn't seem to work properly #50

Closed
Charlie28000 opened this issue Aug 9, 2021 · 3 comments · Fixed by #51
Closed

setChartExpandCollapse doesn't seem to work properly #50

Charlie28000 opened this issue Aug 9, 2021 · 3 comments · Fixed by #51
Assignees
Labels

Comments

@Charlie28000
Copy link

Charlie28000 commented Aug 9, 2021

Despite using setChartExpandCollapse(true) the HTML looks like this:
<div class="orgchart noncollapsable" ...>

The issue can also be observed in the Demo (Drag and Drop Tab): https://addonsv14.flowingcode.com/orgchart

EDIT:
Using setChartDirection(ChartDirectionEnum.TOP_TO_BOTTOM.getAbreviation()) allows collapsing most nodes, except for one last node below the root node. Also the collapse / expand arrows don't show up at all, so the end user wouldn't know, that the nodes are collapsable.

@paodb
Copy link
Member

paodb commented Aug 9, 2021

Hi @Charlie28000 good catch on the collapsable issue. I was just able to reproduce it and I'll work on the fix.

Regarding "Using setChartDirection(ChartDirectionEnum.TOP_TO_BOTTOM.getAbreviation()) allows collapsing most nodes, except for one last node below the root node." Please note that the collapsable functionality comes from the original library, our add-on only gives you a way to set it from Java (see this example from the library). If you think this is an issue can you please create a separate ticket with an example/image/gif showing that behavior? Thanks.

@Charlie28000
Copy link
Author

Hi @paodb,
thank you very much! Will the Vaadin Component (https://vaadin.com/directory/component/orgchart-add-on) also be updated?
Okay, I'll investigate a little bit further and create a ticket regarding the other issue, providing screenshots.

@paodb
Copy link
Member

paodb commented Aug 10, 2021

Hi @Charlie28000, we just did a new release of the component that contains this fix, version 4.2.1. Thanks again for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants