Maintenance/pnpm vite jsx (Enhancements to the Project Infrastructure) #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed Yarn dependency and replaced with PNPM - Changed Frontend to render via vite
…ug/rework-redis-connection # Conflicts: # packages/components/package.json # packages/ui/src/ui-component/dialog/ViewMessagesDialog.jsx # packages/ui/src/views/apikey/index.jsx # packages/ui/src/views/assistants/AssistantDialog.jsx # packages/ui/src/views/chatflows/index.jsx # packages/ui/src/views/credentials/index.jsx
|
wow, these are all the stuff I wanted to upgrade but have not time yet, will definitely take a good look! |
|
sorry for the conflict, just merged in a PR, probably you have to update all the import path for the ui again |
….json to preinstall PNPM only.
- seperated out package locks per package
…aintenance/pnpm-vite-jsx # Conflicts: # packages/ui/src/views/canvas/index.jsx # packages/ui/src/views/chatflows/APICodeDialog.jsx # packages/ui/src/views/chatmessage/ChatMessage.jsx
|
@HenryHengZJ Take a look now. Both workflows should run now. Sorry lots of places needed updating to get this all to run. |
# Conflicts: # packages/components/package.json
…e-fork/Flowise into maintenance/vite-pnpm-tsup # Conflicts: # packages/ui/pnpm-lock.yaml # packages/ui/vite.config.js
…aintenance/vite-pnpm-tsup # Conflicts: # packages/ui/src/layout/MainLayout/Header/ProfileSection/index.jsx # packages/ui/src/ui-component/button/FlowListMenu.jsx # packages/ui/src/views/chatflows/index.jsx
Bring PR Current.
|
@HenryHengZJ I brought the branch up to date. Everything is looking good on my end only thing I changed was adding TSC-watch for server dev mode. It's much easier. |
Minor changes to running in dev mode.
This was referenced Feb 19, 2024
ocflowiseai
approved these changes
Mar 11, 2024
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made several significant updates to the project's foundation, aimed at improving efficiency and standardization. Here's a breakdown of the changes:
Switch from Yarn to PNPM: This change brings multiple advantages:
node_modulesare symlinked and shared, leading to the reuse of 2,860 packages.Committing a Lock File: A lock file has been committed to ensure consistent package versions across different setups.
Introduction of
kill-portin Rootpackage.json: This utility ensures that ports are terminated before running thedevandstartscripts, preventing port conflicts.Standardization of File Extensions in UI Folder: Renamed
.jsfiles to.jsxto adhere to standard practices, enhancing code readability and maintainability.Replacement of Craco with Vite: This upgrade introduces several improvements:
Adding
@/Alias for UI Directory: This alias simplifies referencing within the UI directory, improving code readability and organization.