Always call reverse in map
#1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Downstream tests pass so I'm happy modulo small comment change. If we end up falling victim to Hyrum's law so be it, probably good to know than to be ignorant anyhow. One wonders how many correctness demons like this are lurking in the depths of Zygote's less well-trodden rules...
src/lib/array.jl
Outdated
Comment on lines
169
to
170
| # That lead to https://github.com/FluxML/Zygote.jl/issues/1374 | ||
| # ... and post-1.6 dims is not required to reverse arrays. |
There was a problem hiding this comment.
How about amending the above comment instead? As noted it turned stale the moment we set min compat to 1.6.
There was a problem hiding this comment.
I've shrunk the comment. Not sure what the right policy is for pmap, but I haven't changed it.
This was referenced Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1374 by removing the special case that
_tryreverseonly reverses vectors & tuples.Possibly it will now fail on other types. That's better than silently failing to reverse them.