test(populate): fix flaky test for Automattic#5737

Fonger · Aug 13, 2018 · 06b64df · 06b64df
1 parent 6af5f0b
commit 06b64df
Showing 1 changed file with 18 additions and 7 deletions.
diff --git a/test/model.populate.test.js b/test/model.populate.test.js
@@ -3273,16 +3273,27 @@ describe('model: populate:', function() {
             slice('fans', [0, 5]).
             populate('fans').
             exec(function(err, blogposts) {
-              assert.ifError(error);
+              assert.ifError(err);
 
-              assert.equal(blogposts[0].title, 'Test 1');
-              assert.equal(blogposts[1].title, 'Test 2');
+              assert.ok(blogposts.length === 2);
 
-              assert.equal(blogposts[0].fans[0].name, 'Fan 1');
-              assert.equal(blogposts[0].fans[1].name, 'Fan 2');
+              var test1, test2;
+              if (blogposts[0].title === 'Test 1') {
+                test1 = blogposts[0];
+                test2 = blogposts[1];
+              } else {
+                test1 = blogposts[1];
+                test2 = blogposts[0];
+              }
 
-              assert.equal(blogposts[1].fans[0].name, 'Fan 2');
-              assert.equal(blogposts[1].fans[1].name, 'Fan 1');
+              assert.ok(test1.title === 'Test 1');
+              assert.ok(test2.title === 'Test 2');
+
+              assert.equal(test1.fans[0].name, 'Fan 1');
+              assert.equal(test1.fans[1].name, 'Fan 2');
+
+              assert.equal(test2.fans[0].name, 'Fan 2');
+              assert.equal(test2.fans[1].name, 'Fan 1');
               done();
             });
         });