Add --unlimited-buffer shell output option. (#112)

HISTORY.md

@@ -1,6 +1,10 @@
 History
 =======
 
+## Current
+
+* Add `--unlimited-buffer` shell output option.
+
 ## 2.9.1
 
 * Refactor lodash calls to be tolerant of v3 or v4 as a temporary bandaid to

README.md

@@ -223,6 +223,7 @@ Flags:
 * `--setup`: Single task to run for the entirety of `<action>`
 * `--quiet`: Silence logging
 * `--log-level`: Level to log at (`info`, `warn`, `error`, `none`)
+* `--unlimited-buffer`: Unlimited shell output buffer.
 * `--expand-archetype`: Expand `node_modules/<archetype>` with full path (default: `false`)
 * `--builderrc`: Path to builder config file (default: `.builderrc`)
 
@@ -246,6 +247,7 @@ Flags:
 * `--[no-]bail`: End all processes after the first failure (default: `true`)
 * `--quiet`: Silence logging
 * `--log-level`: Level to log at (`info`, `warn`, `error`, `none`)
+* `--unlimited-buffer`: Unlimited shell output buffer.
 * `--expand-archetype`: Expand `node_modules/<archetype>` with full path (default: `false`)
 * `--builderrc`: Path to builder config file (default: `.builderrc`)
 
@@ -288,6 +290,7 @@ Flags:
 * `--envs-path`: Path to JSON env variable array file (default: `null`)
 * `--quiet`: Silence logging
 * `--log-level`: Level to log at (`info`, `warn`, `error`, `none`)
+* `--unlimited-buffer`: Unlimited shell output buffer.
 * `--expand-archetype`: Expand `node_modules/<archetype>` with full path (default: `false`)
 * `--builderrc`: Path to builder config file (default: `.builderrc`)
 

lib/args.js

@@ -71,6 +71,11 @@ var FLAGS = {
       desc: "Level to log at (`info`, `warn`, `error`, `none`)",
       types: [String],
       default: "info"
+    },
+    "unlimited-buffer": {
+      desc: "Use an unlimited buffer for shell commands",
+      types: [Boolean],
+      default: false
     }
   },
 

lib/runner.js

@@ -157,9 +157,11 @@ var expandArchetype = function (cmd, opts, env) {
  * @returns {Object}            Child process object
  */
 var run = function (cmd, shOpts, opts, callback) {
+  var maxBuffer = opts.unlimitedBuffer ? Infinity : MAX_BUFFER;
+
   // Update shell options and ensure basic structure.
   shOpts = _.extend({
-    maxBuffer: MAX_BUFFER,
+    maxBuffer: maxBuffer,
     env: {}
   }, shOpts);
 

test/server/spec/bin/builder-core.spec.js

@@ -243,6 +243,28 @@ describe("bin/builder-core", function () {
 
     }));
 
+    it("runs a with an unlimited buffer", stdioWrap(function (done) {
+      base.sandbox.spy(Task.prototype, "run");
+      base.mockFs({
+        "package.json": JSON.stringify({
+          "scripts": {
+            "bar": "echo BAR_TASK"
+          }
+        }, null, 2)
+      });
+
+      run({
+        argv: ["node", "builder", "run", "--unlimited-buffer", "bar"]
+      }, function (err) {
+        if (err) { return done(err); }
+
+        expect(Task.prototype.run).to.be.calledOnce;
+        expect(process.stdout.write).to.be.calledWithMatch("BAR_TASK");
+
+        done();
+      });
+
+    }));
     it("runs with quiet log output", stdioWrap(function (done) {
       base.sandbox.spy(Task.prototype, "run");
       base.mockFs({

test/server/spec/lib/args.spec.js

@@ -25,6 +25,7 @@ describe("lib/args", function () {
         builderrc: ".builderrc",
         help: false,
         logLevel: "info",
+        unlimitedBuffer: false,
         quiet: false,
         version: false
       });
@@ -39,6 +40,7 @@ describe("lib/args", function () {
         builderrc: dummyPath,
         help: false,
         logLevel: "info",
+        unlimitedBuffer: false,
         quiet: false,
         version: false
       });