Builder scripts using global npm dependencies instead of locals

[dandelany]

Opening another ticket here per @boygirl 's request... See FormidableLabs/victory#97 for more details & examples.

While I was working on Victory, I discovered that builder scripts which call node binaries like babel end up using the globally installed versions of those binaries, rather than the local versions in node_modules. This is contrary to the behavior of regular old npm scripts which use the local versions. This can cause major problems and build inconsistencies if the user's global module version does not match the local version.

[ryan-roemer]

So this behavior likely comes from: https://github.com/FormidableLabs/builder/blob/master/lib/environment.js#L68-L72

Environment.prototype.updateNodePath = function (archetypeNodePaths) {
  return (this.env.NODE_PATH || "")
    .split(DELIM)
    .filter(function (x) { return x; }) // Remove empty strings
    .concat([CWD_NODE_PATH].concat(archetypeNodePaths || []))
    .join(DELIM);
};

PROPOSAL: Resolve in this order:

• Current Working directory
• Archetype directories
• then pre-existing NODE_PATH

How does that sound?

/cc @dandelany @boygirl @exogen @chaseadamsio

[dandelany]

That sounds pretty good to me! Of course, that order would allow the user's local project deps to override the Archetype's dependency version... But maybe that is preferred, so that the user's project can consciously extend the archetype... I'm still too much of a builder n00b to be sure :)

[ryan-roemer]

Released as builder@2.1.4